Skip to content

Add partial support for Rational APEX file naming conventions to list_unsupported.sh #257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 9, 2019

Conversation

chrisr-diffblue
Copy link
Contributor

These changes make the script work OK with .1.ada and .2.ada file naming
but at the moment gnat2goto still expects to import from .ads files.
We need to switch gnat2goto mode somehow when --apex is specified to this
script.

…_unsupported.sh

These changes make the script work OK with .1.ada and .2.ada file naming
but at the moment gnat2goto still expects to import from .ads files.
We need to switch gnat2goto mode somehow when --apex is specified to this
script.
Copy link
Contributor

@xbauch xbauch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Note this also adds a configuration pragma file that is automatically
including in --apex mode to support "1.ada" and "2.ada" naming schemes.
@chrisr-diffblue
Copy link
Contributor Author

@martin-cs - Would you like to review this now? I've made the script add a .adc file to the gnat2goto command line to handle APEX naming conventions - running this script with --apex should now produce a report for these files. In addition, I've also added a --adc option to allow a user supplied .adc file to be specified instead. I have experimented with using gnatname to generate an appropriate .adc file, but at the moment I cannot get it recognise any of the files it finds as units, so it just generates an empty .adc file.

Copy link
Collaborator

@martin-cs martin-cs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems reasonable. I will try to find a project to test it on.

@martin-cs
Copy link
Collaborator

I have tested this as best as I can without access to a current PTC ApexAda code-base.

@martin-cs martin-cs merged commit dc35772 into diffblue:master Jul 9, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants