$past now supports array and struct types
#1247
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tautschnig
reviewed
Aug 28, 2025
src/verilog/verilog_expr.cpp
Outdated
Comment on lines
536
to
542
| exprt verilog_past_exprt::default_value(const typet &type) | ||
| { | ||
| auto zero = from_integer(0, type()); | ||
| if(zero.is_nil()) | ||
| throw "failed to create $past default value"; | ||
| if(type.id() == ID_array) | ||
| { | ||
| auto &array_type = to_array_type(type); | ||
| auto zero_rec = default_value(array_type.element_type()); | ||
| return array_of_exprt{zero_rec, array_type}; | ||
| } | ||
| else | ||
| return std::move(zero); | ||
| { | ||
| return from_integer(0, type); | ||
| } | ||
| } |
There was a problem hiding this comment.
Shouldn't this use CBMC's zero_initializer or else the one for Verilog being proposed in #1001?
There was a problem hiding this comment.
Yes, the standard seems to guarantee that the value prior to the initial state is the default initial value, will consolidate.
kroening
force-pushed
the
past5-fix
branch
2 times, most recently
from
0951e4e to
940a3ac
Compare
This merges the types in struct and union declarations.
$past returns a "zero value" when asked for a value prior to the initial frame. This adds the zero value for array and struct types.
kroening
changed the title
$past now supports array types$past now supports array and struct types
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
$pastreturns a "zero value" when asked for a value prior to the initial frame. This adds the zero value for array and struct types.