state invariants are now converted into AIG state constraints #478
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kroening
force-pushed
the
trans-to-netlist-invar
branch
3 times, most recently
from
be7194d to
0e030eb
Compare
tautschnig
approved these changes
May 2, 2024
Comment on lines
149
to
168
| Function: has_next_symbol | ||
| Inputs: | ||
| Outputs: | ||
| Purpose: | ||
| \*******************************************************************/ | ||
|
|
||
| static bool has_next_symbol(const exprt &expr) | ||
| { | ||
| auto begin = expr.depth_cbegin(), end = expr.depth_cend(); | ||
| return std::find_if(begin, end, [](const exprt &expr) { | ||
| return expr.id() == ID_next_symbol; | ||
| }) != end; | ||
| } | ||
|
|
||
| /*******************************************************************\ | ||
There was a problem hiding this comment.
Use has_subexpr(expr, ID_next_symbol) from expr_utils.{h,cpp} (which does exactly the above).
| instantiate_convert(prop, dest.var_map, *it, ns, get_message_handler()); | ||
| transition_constraints.push_back(l); | ||
|
|
||
| if(has_next_symbol(*it)) |
There was a problem hiding this comment.
See above: change this to if(has_subexpr(*it, ID_next_symbol)).
The generation of netlists from transition system now uses the state constraint facility of the netlist data structure for state constraints, as opposed to adding everything as a transition constraint. This fixes cases where analyzers over-approximate the model semantics.
kroening
force-pushed
the
trans-to-netlist-invar
branch
from
0e030eb to
1352e26
Compare
Romy15200
pushed a commit
to Romy15200/nws
that referenced
this pull request
Aug 19, 2025
state invariants are now converted into AIG state constraints
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generation of netlists from transition system now uses the state constraint facility of the netlist data structure for state constraints, as opposed to adding everything as a transition constraint.
This fixes cases where analyzers over-approximate the model semantics.