Verilog: add a class for exceptions in the preprocessor #70
Conversation
src/verilog/verilog_preprocessor.cpp
Outdated
| error().source_location = source_location; | ||
| error() << "unknown preprocessor directive \"" << text << "\"" << eom; | ||
| throw 0; | ||
| throw verilog_preprocessor_errort() << "unknown preprocessor directive \"" << text << "\""; |
There was a problem hiding this comment.
I'd have a preference towards RAII: could the constructor please require (!) a string to be passed?
There was a problem hiding this comment.
The class meets the RAII criteria; in particular, all invariants are satisfied. It's like a container, and as such may be constructed empty.
This adds a class for exceptions in the Verilog preprocessor, as opposed to throwing the integer 0.
kroening
force-pushed
the
verilog_preprocessor_error
branch
from
a3d783f to
b581a03
Compare
| throw verilog_preprocessor_errort() | ||
| << "unknown preprocessor directive \"" << text << "\""; |
There was a problem hiding this comment.
I accept that this satisfies RAII, but I am still wondering whether a constructor that takes a std::string wouldn't be the better way forward.
There was a problem hiding this comment.
It would be a bit weird, e.g., in this case you would have
throw verilog_preprocessor_errort("unknown preprocessor directive \"") << text << "\"";
There was a problem hiding this comment.
I would have used + instead of << and have passed the entire string to the constructor. But it’s just a matter of taste, no big deal.
There was a problem hiding this comment.
Yes, but then you'll want numbers, tokens (which have a << operator, but no +), etc.
Verilog: add a class for exceptions in the preprocessor
This adds a class for exceptions in the Verilog preprocessor, as opposed to throwing the integer 0.