Skip to content

Conversation

kroening
Copy link
Collaborator

@kroening kroening commented Jan 6, 2025

The k-induction engine now correctly reports unsupported assumptions, and is then skipped by the engine selection heuristic.

Fixes #921.

@kroening kroening force-pushed the k-induction6-fix branch 7 times, most recently from c568427 to 7cb3f0a Compare January 15, 2025 22:15
The k-induction engine now correctly reports unsupported assumptions, and is
then skipped by the engine selection heuristic.

Fixes #921.
@kroening kroening marked this pull request as ready for review January 16, 2025 18:23
Comment on lines +699 to 700
prop_handles.clear();
prop_handles.resize(no_timeframes, true_exprt());
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since this is now always cleared shouldn't this be returned by value rather than being required as argument?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, will action.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Will be separate PR.

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kroening kroening merged commit f334106 into main Jan 16, 2025
9 checks passed
@kroening kroening deleted the k-induction6-fix branch January 16, 2025 20:10
Romy15200 pushed a commit to Romy15200/nws that referenced this pull request Aug 19, 2025
Engine heuristic: fix for assumptions unsupported by k-induction
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Problem with engine heuristic
2 participants