Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SwtScheduler that honors the Scheduler/Worker contracts #1

Merged
merged 1 commit into from
May 3, 2016

Conversation

akarnokd
Copy link
Contributor

@akarnokd akarnokd commented May 1, 2016

This PR replaces the anonymous scheduler implementation with a named SwtScheduler implementation that honors the Scheduler/Worker contracts of RxJava, namely the tracking and mass-unsubscription requirement.

Great talk at EclipseCon btw! Would this library work with Eclipse RAP?

@akarnokd akarnokd reopened this May 1, 2016
@nedtwigg
Copy link
Member

nedtwigg commented May 3, 2016

Wow, what a contribution! Thanks very much!

Great talk at EclipseCon btw!

Thanks, glad you liked it!

Would this library work with Eclipse RAP?

I think so, but I haven't tested it. SwtExec only depends on Display.asyncExec / Display.syncExec and dispose events, and it looks like RAP implements these in a way that will work with DurianSWT.

@nedtwigg nedtwigg merged commit 3707f0a into diffplug:master May 3, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants