Skip to content

Change colors to match GitHub's theming #11

@nedtwigg

Description

@nedtwigg

There are links. There is also bold and italic and bold-italic and inline code too.

And it can all be in quotes - the links and the bold and italic and bold-italic and inline code.

import { CONFIG, type ModeType } from '../lib/config'
import { logger } from '../lib/logger'

const enhancers = new EnhancerRegistry()

export default defineContentScript({
  main() {
    if ((CONFIG.MODE as ModeType) === 'PLAYGROUNDS_PR') {
      githubPrNewCommentContentScript()
      return
    }
  },
  matches: ['<all_urls>'],
  runAt: 'document_end',
})

And here it is again for easy copy-pasting:

There are [links](https://selfie.dev/). There is also **bold** and *italic* and ***bold-italic*** and `inline code` too.

> And it can all be in quotes - the [links](https://selfie.dev/) and the **bold** and *italic* and **bold-italic*** and `inline code`.

```typescript
import { CONFIG, type ModeType } from '../lib/config'
import { logger } from '../lib/logger'

const enhancers = new EnhancerRegistry()

export default defineContentScript({
  main() {
    if ((CONFIG.MODE as ModeType) === 'PLAYGROUNDS_PR') {
      githubPrNewCommentContentScript()
      return
    }
  },
  matches: ['<all_urls>'],
  runAt: 'document_end',
})

Goal

The goal is for the preview text to look as similar to the rendered text as possible. Switching edit ->preview shouldn't feel like a big change.

GitHub colors

  • text color: rgb(31, 35, 40)
  • quote text color: rgb(89, 99, 110)
  • link color: rgb(9, 105, 218)
  • inline code background color: rgba(129, 139, 152, 0.12) aka rgb(240, 241, 242)
  • block code background color: rgb(246, 248, 250)

Proposed new colors to add

  • link url: rgb(142, 182, 241)
  • bold: rgb(45, 1, 142)
  • italic: rgb(126, 123, 255)
  • bold-italic: rgb(174, 52, 151)

The result (as shown in this prototype) would be:

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions