Skip to content

Refactor har:view for better maintainability #19

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 6, 2025
Merged

Refactor har:view for better maintainability #19

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
9442ded
Simplify har-view using `keyof typeof PAGES`.
nedtwigg Sep 6, 2025
836fb1f
Combine two copy-pasted route handlers into one.
nedtwigg Sep 6, 2025
8f5c55b
Extract gitcasso injection into its own script.
nedtwigg Sep 6, 2025
032e04d
asset handling is now website-agnostic
nedtwigg Sep 6, 2025
2d97bad
biome:fix
nedtwigg Sep 6, 2025
b8721eb
Couple renames for more consistency.
nedtwigg Sep 6, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion browser-extension/tests/test-utils.ts → browser-extension/tests/har-fixture-utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@ import path from 'node:path'
import { fileURLToPath } from 'node:url'
import type { Har as HarFile } from 'har-format'
import { parseHTML } from 'linkedom'
import { PAGES } from './har-index'
import { PAGES } from './har/_har-index'

const __dirname = path.dirname(fileURLToPath(import.meta.url))

Expand Down
4 changes: 2 additions & 2 deletions browser-extension/tests/fixture-har.ts → browser-extension/tests/har-fixture.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ vi.mock('../src/overtype/overtype', () => {
})

import { describe as baseDescribe, test as baseTest, expect } from 'vitest'
import type { PAGES } from './har-index'
import { cleanupDOM, setupHarDOM } from './test-utils'
import type { PAGES } from './har/_har-index'
import { cleanupDOM, setupHarDOM } from './har-fixture-utils'

export const describe = baseDescribe

Expand Down
2 changes: 1 addition & 1 deletion browser-extension/tests/har-record.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import fs from 'node:fs/promises'
import path from 'node:path'
import { chromium } from '@playwright/test'
import { PAGES } from './har-index'
import { PAGES } from './har/_har-index'

// Convert glob pattern to regex
function globToRegex(pattern: string): RegExp {
Expand Down
Loading