Skip to content

Introduce StrippedLocation for mocking browser location and domain #53

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 17, 2025
Merged

Introduce StrippedLocation for mocking browser location and domain #53

merged 6 commits into from
Sep 17, 2025

Conversation

nedtwigg
Copy link
Member

Introduce StrippedLocation which we pass around explicitly

export interface StrippedLocation {
  host: string
  pathname: string
}

This lets us mock better in our test environment.

@nedtwigg nedtwigg marked this pull request as ready for review September 17, 2025 23:37
@nedtwigg nedtwigg merged commit 9195392 into main Sep 17, 2025
1 check passed
@nedtwigg nedtwigg deleted the feat/stripped-location branch September 17, 2025 23:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@nedtwigg