Skip to content

Cleanup and centralize all our "once per pageload" stuff #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Sep 18, 2025
Merged

Cleanup and centralize all our "once per pageload" stuff #61

merged 6 commits into from
Sep 18, 2025

Conversation

nedtwigg
Copy link
Member

  • the prepareForFirstEnhancement thing didn't really work out since it turned out that we'll have so many implementations that need to initialize the same things
  • so I made this refactor, merge it if it looks okay to you
  • it has an important bugfix in its last commit (annoying) so if you don't want to merge it, make sure you at least cherry-pick that last commit

@nedtwigg nedtwigg requested a review from WebsByTodd September 18, 2025 10:03
@nedtwigg nedtwigg force-pushed the feat/once-per-fullpageload branch from 091624c to fe425af Compare September 18, 2025 10:06
@nedtwigg nedtwigg marked this pull request as ready for review September 18, 2025 10:16
@nedtwigg nedtwigg merged commit 1e03587 into main Sep 18, 2025
1 check passed
@nedtwigg nedtwigg deleted the feat/once-per-fullpageload branch September 18, 2025 17:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@WebsByTodd WebsByTodd Awaiting requested review from WebsByTodd

Assignees

@WebsByTodd WebsByTodd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nedtwigg @WebsByTodd