Skip to content

Better table upper decorations #95

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 29, 2025
Merged

Better table upper decorations #95

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
bc7dabc
Better table upper decorations.
WebsByTodd Sep 29, 2025
db3fc26
Snapshots.
WebsByTodd Sep 29, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 9 additions & 7 deletions src/lib/enhancers/github/GitHubIssueAppendEnhancer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,13 +90,15 @@ export class GitHubIssueAppendEnhancer
<span className="flex h-4 w-4 flex-shrink-0 items-center justify-center">
<IssueOpenedIcon size={16} />
</span>
#{spot.number}
<a
href={`https://${spot.domain}/${spot.slug}`}
className="truncate hover:underline"
>
{spot.slug}
</a>
<span>
#{spot.number} |{" "}
<a
href={`https://${spot.domain}/${spot.slug}`}
className="truncate hover:underline"
>
{spot.slug}
</a>
</span>
</>
)
}
Expand Down
17 changes: 12 additions & 5 deletions src/lib/enhancers/github/GitHubIssueCreateEnhancer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { IssueOpenedIcon } from "@primer/octicons-react"
import OverType, { type OverTypeInstance } from "overtype"
import type {
CommentEnhancer,
Expand Down Expand Up @@ -74,13 +75,19 @@ export class GitHubIssueCreateEnhancer
}

tableUpperDecoration(spot: GitHubIssueCreateSpot): React.ReactNode {
const { slug } = spot
return (
<>
<span>New Issue</span>
<span className="font-mono text-muted-foreground text-sm">
{" "}
{slug}{" "}
<span className="flex h-4 w-4 flex-shrink-0 items-center justify-center">
<IssueOpenedIcon size={16} />
</span>
<span>
New |{" "}
<a
href={`https://${spot.domain}/${spot.slug}`}
className="truncate hover:underline"
>
{spot.slug}
</a>
</span>
</>
)
Expand Down
16 changes: 13 additions & 3 deletions src/lib/enhancers/github/GitHubPrAppendEnhancer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { FeedPullRequestOpenIcon } from "@primer/octicons-react"
import OverType, { type OverTypeInstance } from "overtype"
import type React from "react"
import type {
Expand Down Expand Up @@ -83,11 +84,20 @@ export class GitHubPrAppendEnhancer
}

tableUpperDecoration(spot: GitHubPrAppendSpot): React.ReactNode {
const { slug, number } = spot
return (
<>
<span className="font-mono text-muted-foreground text-sm">{slug}</span>
<span className="ml-2 font-medium">PR #{number}</span>
<span className="flex h-4 w-4 flex-shrink-0 items-center justify-center">
<FeedPullRequestOpenIcon size={16} />
</span>
<span>
#{spot.number} |{" "}
<a
href={`https://${spot.domain}/${spot.slug}`}
className="truncate hover:underline"
>
{spot.slug}
</a>
</span>
</>
)
}
Expand Down
17 changes: 12 additions & 5 deletions src/lib/enhancers/github/GitHubPrCreateEnhancer.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,4 @@
import { FeedPullRequestOpenIcon } from "@primer/octicons-react"
import OverType, { type OverTypeInstance } from "overtype"
import type {
CommentEnhancer,
Expand Down Expand Up @@ -89,13 +90,19 @@ export class GitHubPrCreateEnhancer
}

tableUpperDecoration(spot: GitHubPrCreateSpot): React.ReactNode {
const { slug } = spot
return (
<>
<span>New PR</span>
<span className="font-mono text-muted-foreground text-sm">
{" "}
{slug}{" "}
<span className="flex h-4 w-4 flex-shrink-0 items-center justify-center">
<FeedPullRequestOpenIcon size={16} />
</span>
<span>
New |{" "}
<a
href={`https://${spot.domain}/${spot.slug}`}
className="truncate hover:underline"
>
{spot.slug}
</a>
</span>
</>
)
Expand Down
158 changes: 104 additions & 54 deletions tests/lib/enhancers/__snapshots__/gh-ui.test.ts.snap
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,14 +13,18 @@ exports[`github ui > gh_issue:should render correct UI elements 1`] = `
size={16}
/>
</span>
#
523
<a
className="truncate hover:underline"
href="https://github.com/diffplug/selfie"
>
diffplug/selfie
</a>
<span>
#
523
|

<a
className="truncate hover:underline"
href="https://github.com/diffplug/selfie"
>
diffplug/selfie
</a>
</span>
</React.Fragment>,
},
]
Expand All @@ -46,14 +50,18 @@ exports[`github ui > gh_issue_edit:should render correct UI elements 1`] = `
size={16}
/>
</span>
#
56
<a
className="truncate hover:underline"
href="https://github.com/diffplug/gitcasso"
>
diffplug/gitcasso
</a>
<span>
#
56
|

<a
className="truncate hover:underline"
href="https://github.com/diffplug/gitcasso"
>
diffplug/gitcasso
</a>
</span>
</React.Fragment>,
},
]
Expand Down Expand Up @@ -86,14 +94,18 @@ exports[`github ui > gh_issue_edit_multiple:should render correct UI elements 1`
size={16}
/>
</span>
#
3
<a
className="truncate hover:underline"
href="https://github.com/diffplug/testing-deletable"
>
diffplug/testing-deletable
</a>
<span>
#
3
|

<a
className="truncate hover:underline"
href="https://github.com/diffplug/testing-deletable"
>
diffplug/testing-deletable
</a>
</span>
</React.Fragment>,
},
]
Expand All @@ -105,15 +117,22 @@ exports[`github ui > gh_issue_new:should render correct UI elements 1`] = `
"for": "id=:r34: name=null className=prc-Textarea-TextArea-13q4j focus-visible overtype-input",
"title": "New issue title",
"upperDecoration": <React.Fragment>
<span>
New Issue
</span>
<span
className="font-mono text-muted-foreground text-sm"
className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
>
<IssueOpenedIcon
size={16}
/>
</span>
<span>
New |

diffplug/gitcasso

<a
className="truncate hover:underline"
href="https://github.com/diffplug/gitcasso"
>
diffplug/gitcasso
</a>
</span>
</React.Fragment>,
},
Expand All @@ -128,15 +147,23 @@ exports[`github ui > gh_pr:should render correct UI elements 1`] = `
#517",
"upperDecoration": <React.Fragment>
<span
className="font-mono text-muted-foreground text-sm"
className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
>
diffplug/selfie
<FeedPullRequestOpenIcon
size={16}
/>
</span>
<span
className="ml-2 font-medium"
>
PR #
<span>
#
517
|

<a
className="truncate hover:underline"
href="https://github.com/diffplug/selfie"
>
diffplug/selfie
</a>
</span>
</React.Fragment>,
},
Expand All @@ -159,15 +186,23 @@ exports[`github ui > gh_pr_edit:should render correct UI elements 1`] = `
#58",
"upperDecoration": <React.Fragment>
<span
className="font-mono text-muted-foreground text-sm"
className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
>
diffplug/gitcasso
<FeedPullRequestOpenIcon
size={16}
/>
</span>
<span
className="ml-2 font-medium"
>
PR #
<span>
#
58
|

<a
className="truncate hover:underline"
href="https://github.com/diffplug/gitcasso"
>
diffplug/gitcasso
</a>
</span>
</React.Fragment>,
},
Expand Down Expand Up @@ -196,15 +231,23 @@ exports[`github ui > gh_pr_edit_multiple:should render correct UI elements 1`] =
#5",
"upperDecoration": <React.Fragment>
<span
className="font-mono text-muted-foreground text-sm"
className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
>
diffplug/testing-deletable
<FeedPullRequestOpenIcon
size={16}
/>
</span>
<span
className="ml-2 font-medium"
>
PR #
<span>
#
5
|

<a
className="truncate hover:underline"
href="https://github.com/diffplug/testing-deletable"
>
diffplug/testing-deletable
</a>
</span>
</React.Fragment>,
},
Expand All @@ -217,15 +260,22 @@ exports[`github ui > gh_pr_new:should render correct UI elements 1`] = `
"for": "id=pull_request_body name=pull_request[body] className=js-comment-field js-paste-markdown js-task-list-field js-quick-submit FormControl-textarea CommentBox-input js-size-to-fit size-to-fit js-session-resumable js-saved-reply-shortcut-comment-field CommentBox-input--large overtype-input",
"title": "Update README.md",
"upperDecoration": <React.Fragment>
<span>
New PR
</span>
<span
className="font-mono text-muted-foreground text-sm"
className="flex h-4 w-4 flex-shrink-0 items-center justify-center"
>
<FeedPullRequestOpenIcon
size={16}
/>
</span>
<span>
New |

diffplug/selfie

<a
className="truncate hover:underline"
href="https://github.com/diffplug/selfie"
>
diffplug/selfie
</a>
</span>
</React.Fragment>,
},
Expand Down