Skip to content

Less ideal but more stable active nav link highlight #17

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Aug 25, 2024

Conversation

WebsByTodd
Copy link
Collaborator

No description provided.

…ere always 0 on mobile when using `document.getElementById`. Use the `useLayoutEffect` hook, a ref, and grab the measurement every time the menu opens instead.
…ments to highlight the currently active route.
Copy link

cloudflare-workers-and-pages bot commented Jul 17, 2024

Deploying gitfromscratch with  Cloudflare Pages  Cloudflare Pages

Latest commit: d2012eb
Status: ✅  Deploy successful!
Preview URL: https://e5d5819c.gitfromscratch.pages.dev
Branch Preview URL: https://fix-nav-ref-nonsense.gitfromscratch.pages.dev

View logs

@nedtwigg nedtwigg mentioned this pull request Jul 17, 2024
@nedtwigg nedtwigg merged commit f694d91 into main Aug 25, 2024
1 check passed
@nedtwigg nedtwigg deleted the fix/nav-ref-nonsense branch August 25, 2024 22:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants