Carriage return handling #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ure it only contains unix newlines.
|
@nedtwigg just pushed a new line reader |
- redo jvm line reader to keep incremental reads and figure it out useUnixNewLines - still got some failures, but want to get feedback about the line reader
jknack
force-pushed
the
feat/carriage-return
branch
from
266c1cc
to
f90a8cc
Compare
nedtwigg
commented
Sep 9, 2023
selfie-runner-junit5/src/main/kotlin/com/diffplug/selfie/junit5/SelfieConfig.kt
Outdated
Show resolved
Hide resolved
selfie-runner-junit5/src/main/kotlin/com/diffplug/selfie/junit5/SelfieConfig.kt
Outdated
Show resolved
Hide resolved
selfie-lib/src/jvmMain/kotlin/com/diffplug/selfie/SnapshotFile.jvm.kt
Outdated
Show resolved
Hide resolved
- there was setting the content to just `\r\n` or `\n` produces an empty snapshot making the build unstable
- it must assume always unixline
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't preserve carriage returns in general, e.g.
but we do want to keep whatever the user has. We use exclusively
\ninternally, but if a user is using\r\nwe should not bother them with this triviality.@jknack this is a nice easy warmup, no dependencies on any of the other open PRs.