Cannot resolve external dependency com.google.googlejavaformat:google-java-format:1.3

[arulrajnet]

Recently I have upgraded to spotless 3.4.0. Gradle 3.5 and Java 1.8
My spotless config

buildscript {
  repositories {
    mavenCentral()
    maven { url 'https://plugins.gradle.org/m2/' }
  }
  dependencies {
    classpath 'com.diffplug.spotless:spotless-plugin-gradle:3.4.0'
    classpath 'com.google.googlejavaformat:google-java-format:1.3'
  }
}

apply plugin: com.diffplug.gradle.spotless.SpotlessPlugin

spotless {
  java {
    googleJavaFormat('1.3')
    custom 'Lambda fix', { it.replace('} )', '})').replace('} ,', '},') }
    importOrder(['java', 'javax', 'org', 'com'])
    trimTrailingWhitespace()
    removeUnusedImports()
  }
  format 'misc', {
    target '**/.gitignore', '**/*.gradle', '**/*.md', '**/*.sh'
    indentWithSpaces(2)
    trimTrailingWhitespace()
    endWithNewline()
  }
}

I am getting following error.

:spotlessJava
You probably need to add a repository containing the '[com.google.googlejavaformat:google-java-format:1.3]' artifact, e.g.: 'buildscript { repositories { mavenCentral() }}'
org.gradle.api.artifacts.ResolveException: Could not resolve all dependencies for configuration ':detachedConfiguration1'.
        at org.gradle.api.internal.artifacts.ivyservice.DefaultLenientConfiguration.rethrowFailure(DefaultLenientConfiguration.java:192)
        at 
 (tons more)

If I downgrade to 3.0.0 its just working fine for the same config.

---

EDIT by @nedtwigg: this is a long thread, but the resolution was that the buildscript block above must appear in build.gradle, it's not enough for it to be appear in a separate file, such as spotless.gradle, which gets included.

[nedtwigg]

At the top of the error message, it says:

You probably need to add a repository containing the '[com.google.googlejavaformat:google-java-format:1.3]' artifact, e.g.: 'buildscript { repositories { mavenCentral() }}'

If you add buildscript { repositories { mavenCentral() } }, it will fix your problem. This was changed in Spotless 3.3.0, you can see the reasoning in #99.

[arulrajnet]

Please check my spotless config mavenCentral() is already there in repositories. I have added google-java-format as dependencies too.

[nedtwigg]

Does your project have subprojects? Your project file as written above works for me. If you have subprojects, you might need a block like this:

subprojects {
  buildscript {
    repositories {
      mavenCentral()
    }
  }
}

[arulrajnet]

@nedtwigg thanks for your commitment. I don't use subproject, its just plain vennila gradle java project.

To reproduce that clone this repo https://github.com/arulrajnet/gradle-java-template . Then just run gradle spotlesscheck . You will get the above mentioned error.

[nedtwigg]

The code you linked to does not have buildscript { repositories { mavenCentral() } }. If I add that little snippet to the code, then it works.

[arulrajnet]

This spoless.gradle file already has that snippet.

But adding that snippet in build.gradle solves the problem. Thanks

[nedtwigg]

Ahhhh. Interesting. I've never quite understood how include works, and now I understand it less than ever ;-) Glad you got your problem solved, and thanks for sharing the journey here, I'm sure others will bump into this at some point as well :)

[fvgh]

The problem is that spotless takes the buildscript from each individual project.
But a buildscript closure is bound to the underlying script.

This is also the reason why you have to configure the repository for all sub-projects. I personally find this not so intuitive. Normally I would expect that the buildscript is used, where apply plugin for spotless is called.

When applying the new spotless version to Junit, there were similar problems.

@nedtwigg If you agree to my proposal (using buildscript where the apply plugin is called), I can have a look whether/how the behavior can be changed.

[nedtwigg]

If it's possible, I'm all for it! Another possible answer is to use the buildscript for the root project. I think it's reasonable to have different repositories for the build than for the artifacts being built (this was the usecase which drove #99 in the first place), but it's harder to understand needing different buildscript repos for different projects...

[fvgh]

rootProject is possible, but still does not help (at least according to my understanding of the Gradle Doc) if you use apply plugin and have your spotless config in a separate script, which I think is quite common scenario.
Let me look for the right hook and the solution will cover (I'll add tests 😄 ) both scenarios.

[fvgh]

@nedtwigg As you assumed, it is not possible to access the buildscript from which the spotless has been created. I looked at the Gradle code and I am pretty sure that I have not missed anything.
What I currently not fully understand are our needs. Do we (except for snapshots and testing) need any other repository than mavenCentral?
I provided a draft proposal which always adds mavenCentral to the end of the project build repositories if it is missing. Since gradle uses the first match, this solution should not conflict with any user testing of mavenLocal or proxy configuration.
Wouldn't that solve 99% of the user problems?
I tested it briefly with JUnit and provided a simple unit test.
If you see no conflicts and agree that this should meet most users needs, I would make some more checks and finalize the proposal.

[nedtwigg]

This makes me a little nervous. It's not uncommon for a company to proxy all access to external repositories, so automatically adding mavenCentral is a fairly promiscuous behavior. One reason for this is to ensure that all artifacts from the public internet have a local proxy, and the second more important reason to proxy is so that every library can be vetted by a security team before it is allowed to be part of the build.

The nice thing about the "root project" workaround I mentioned above is that we would never add a repository that the user hasn't already approved.