Skip to content

Conversation

Pankraz76
Copy link
Contributor

Please DO NOT FORCE PUSH. Don't worry about messy history, it's easier to do code review if we can tell what happened after the review, and force pushing breaks that.

Please make sure that your PR allows edits from maintainers. Sometimes it's faster for us to just fix something than it is to describe how to fix it.

Allow edits from maintainers

After creating the PR, please add a commit that adds a bullet-point under the [Unreleased] section of CHANGES.md, plugin-gradle/CHANGES.md, and plugin-maven/CHANGES.md which includes:

  • a summary of the change
  • either
    • a link to the issue you are resolving (for small changes)
    • a link to the PR you just created (for big changes likely to have discussion)

If your change only affects a build plugin, and not the lib, then you only need to update the plugin-foo/CHANGES.md for that plugin.

If your change affects lib in an end-user-visible way (fixing a bug, updating a version) then you need to update CHANGES.md for both the lib and all build plugins. Users of a build plugin shouldn't have to refer to lib to see changes that affect them.

This makes it easier for the maintainers to quickly release your changes :)

@Pankraz76 Pankraz76 marked this pull request as ready for review October 4, 2025 14:24
@Pankraz76 Pankraz76 force-pushed the ImportLayoutStyle-pr branch from febeee1 to 66ac9b9 Compare October 4, 2025 15:10
@Pankraz76
Copy link
Contributor Author

kind of wack but might be an increment. This code base really worked it out. Congratulations for the great success. @nedtwigg

@nedtwigg nedtwigg merged commit 90ff85a into diffplug:main Oct 4, 2025
19 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants