Add error-prone.picnic.tech featuring StaticImport

build.gradle

@@ -12,6 +12,7 @@ repositories {
 apply from: rootProject.file('gradle/java-publish.gradle')
 apply from: rootProject.file('gradle/changelog.gradle')
 allprojects {
+	apply from: rootProject.file('gradle/error-prone.gradle')
 	apply from: rootProject.file('gradle/rewrite.gradle')
 	apply from: rootProject.file('gradle/spotless.gradle')
 }

gradle/error-prone.gradle

@@ -0,0 +1,265 @@
+import static java.lang.System.getenv
+
+apply plugin: 'net.ltgt.errorprone'
+
+dependencies {
+	errorprone('com.google.errorprone:error_prone_core:2.42.0')
+	errorprone('tech.picnic.error-prone-support:error-prone-contrib:0.25.0')
+	errorprone('tech.picnic.error-prone-support:refaster-runner:0.25.0')
+}
+
+tasks.withType(JavaCompile).configureEach {
+	options.errorprone {
+		allErrorsAsWarnings = true
+		enable(
+				'StaticImport',
+				'StringJoin',
+				)
+		disable(
+				'DefaultCharset', // contract on ByteArrayOutputStream suggest default encoding.
+				// bug
+				'AddNullMarkedToPackageInfo',
+				'Slf4jLogStatement',
+				)
+		// dev opt-in
+		if (!getenv().containsKey('CI') && getenv('IN_PLACE')?.toBoolean()) {
+			// apply
+			errorproneArgs.addAll(
+					'-XepPatchLocation:IN_PLACE',
+					'-XepPatchChecks:' +
+					// 'AddNullMarkedToPackageInfo,' +
+					// 'AlwaysThrows,' +
+					// 'AmbiguousJsonCreator,' +
+					// 'AndroidInjectionBeforeSuper,' +
+					// 'ArrayEquals,' +
+					// 'ArrayFillIncompatibleType,' +
+					// 'ArrayHashCode,' +
+					// 'ArrayToString,' +
+					// 'ArraysAsListPrimitiveArray,' +
+					// 'AssertJNullnessAssertion,' +
+					// 'AsyncCallableReturnsNull,' +
+					// 'AsyncFunctionReturnsNull,' +
+					// 'AutoValueBuilderDefaultsInConstructor,' +
+					// 'AutoValueConstructorOrderChecker,' +
+					// 'AutowiredConstructor,' +
+					// 'BadAnnotationImplementation,' +
+					// 'BadShiftAmount,' +
+					// 'BanJNDI,' +
+					// 'BoxedPrimitiveEquality,' +
+					// 'BundleDeserializationCast,' +
+					// 'CanonicalAnnotationSyntax,' +
+					// 'CanonicalClassNameUsage,' +
+					// 'ChainingConstructorIgnoresParameter,' +
+					// 'CheckNotNullMultipleTimes,' +
+					// 'CheckReturnValue,' +
+					// 'ClassCastLambdaUsage,' +
+					// 'CollectionIncompatibleType,' +
+					// 'CollectionToArraySafeParameter,' +
+					// 'CollectorMutability,' +
+					// 'ComparableType,' +
+					// 'ComparingThisWithNull,' +
+					// 'ComparisonOutOfRange,' +
+					// 'CompatibleWithAnnotationMisuse,' +
+					// 'CompileTimeConstant,' +
+					// 'ComputeIfAbsentAmbiguousReference,' +
+					// 'ConditionalExpressionNumericPromotion,' +
+					// 'ConstantNaming,' +
+					// 'ConstantOverflow,' +
+					// 'DaggerProvidesNull,' +
+					// 'DangerousLiteralNull,' +
+					// 'DeadException,' +
+					// 'DeadThread,' +
+					// 'DereferenceWithNullBranch,' +
+					// 'DirectReturn,' +
+					// 'DiscardedPostfixExpression,' +
+					// 'DoNotCall,' +
+					// 'DoNotMock,' +
+					// 'DoubleBraceInitialization,' +
+					// 'DuplicateMapKeys,' +
+					// 'DurationFrom,' +
+					// 'DurationGetTemporalUnit,' +
+					// 'DurationTemporalUnit,' +
+					// 'DurationToLongTimeUnit,' +
+					// 'EagerStringFormatting,' +
+					// 'EmptyMethod,' +
+					// 'EmptyMonoZip,' +
+					// 'EqualsHashCode,' +
+					// 'EqualsNaN,' +
+					// 'EqualsNull,' +
+					// 'EqualsReference,' +
+					// 'EqualsWrongThing,' +
+					// 'ExplicitArgumentEnumeration,' +
+					// 'ExplicitEnumOrdering,' +
+					// 'FloggerFormatString,' +
+					// 'FloggerLogString,' +
+					// 'FloggerLogVarargs,' +
+					// 'FloggerSplitLogStatement,' +
+					// 'FluxFlatMapUsage,' +
+					// 'FluxImplicitBlock,' +
+					// 'ForOverride,' +
+					// 'FormatString,' +
+					// 'FormatStringAnnotation,' +
+					// 'FormatStringConcatenation,' +
+					// 'FromTemporalAccessor,' +
+					// 'FunctionalInterfaceMethodChanged,' +
+					// 'FunctionalInterfaceMethodChanged,' +
+					// 'FuturesGetCheckedIllegalExceptionType,' +
+					// 'FuzzyEqualsShouldNotBeUsedInEqualsMethod,' +
+					// 'GetClassOnAnnotation,' +
+					// 'GetClassOnClass,' +
+					// 'GuardedBy,' +
+					// 'GuiceAssistedInjectScoping,' +
+					// 'GuiceAssistedParameters,' +
+					// 'GuiceInjectOnFinalField,' +
+					// 'HashtableContains,' +
+					// 'IdentityBinaryExpression,' +
+					// 'IdentityConversion,' +
+					// 'IdentityHashMapBoxing,' +
+					// 'Immutable,' +
+					// 'ImmutableEnumChecker,' +
+					// 'ImmutablesSortedSetComparator,' +
+					// 'ImpossibleNullComparison,' +
+					// 'Incomparable,' +
+					// 'IncompatibleArgumentType,' +
+					// 'IncompatibleModifiers,' +
+					// 'IndexOfChar,' +
+					// 'InexactVarargsConditional,' +
+					// 'InfiniteRecursion,' +
+					// 'InjectMoreThanOneScopeAnnotationOnClass,' +
+					// 'InjectOnMemberAndConstructor,' +
+					// 'InlineMeValidator,' +
+					// 'InstantTemporalUnit,' +
+					// 'InvalidJavaTimeConstant,' +
+					// 'InvalidPatternSyntax,' +
+					// 'InvalidTimeZoneID,' +
+					// 'InvalidZoneId,' +
+					// 'IsInstanceIncompatibleType,' +
+					// 'IsInstanceLambdaUsage,' +
+					// 'IsInstanceOfClass,' +
+					// 'IsLoggableTagLength,' +
+					// 'JUnit3TestNotRun,' +
+					// 'JUnit4ClassAnnotationNonStatic,' +
+					// 'JUnit4SetUpNotRun,' +
+					// 'JUnit4TearDownNotRun,' +
+					// 'JUnit4TestNotRun,' +
+					// 'JUnit4TestsNotRunWithinEnclosed,' +
+					// 'JUnitAssertSameCheck,' +
+					// 'JUnitClassModifiers,' +
+					// 'JUnitMethodDeclaration,' +
+					// 'JUnitNullaryParameterizedTestDeclaration,' +
+					// 'JUnitParameterMethodNotFound,' +
+					// 'JUnitValueSource,' +
+					// 'JavaxInjectOnAbstractMethod,' +
+					// 'JodaToSelf,' +
+					// 'LenientFormatStringValidation,' +
+					// 'LexicographicalAnnotationAttributeListing,' +
+					// 'LexicographicalAnnotationListing,' +
+					// 'LiteByteStringUtf8,' +
+					// 'LocalDateTemporalAmount,' +
+					// 'LockOnBoxedPrimitive,' +
+					// 'LoopConditionChecker,' +
+					// 'LossyPrimitiveCompare,' +
+					// 'MathRoundIntLong,' +
+					// 'MislabeledAndroidString,' +
+					// 'MisleadingEmptyVarargs,' +
+					// 'MisleadingEscapedSpace,' +
+					// 'MisplacedScopeAnnotations,' +
+					// 'MissingOverride,' +
+					// 'MissingSuperCall,' +
+					// 'MissingTestCall,' +
+					// 'MisusedDayOfYear,' +
+					// 'MisusedWeekYear,' +
+					// 'MixedDescriptors,' +
+					// 'MockitoMockClassReference,' +
+					// 'MockitoStubbing,' +
+					// 'MockitoUsage,' +
+					// 'ModifyingCollectionWithItself,' +
+					// 'MongoDBTextFilterUsage,' +
+					// 'MoreThanOneInjectableConstructor,' +
+					// 'MustBeClosedChecker,' +
+					// 'NCopiesOfChar,' +
+					// 'NestedOptionals,' +
+					// 'NestedPublishers,' +
+					// 'NoCanIgnoreReturnValueOnClasses,' +
+					// 'NonCanonicalStaticImport,' +
+					// 'NonEmptyMono,' +
+					// 'NonFinalCompileTimeConstant,' +
+					// 'NonRuntimeAnnotation,' +
+					// 'NonStaticImport,' +
+					// 'NullArgumentForNonNullParameter,' +
+					// 'NullTernary,' +
+					// 'NullableOnContainingClass,' +
+					// 'OptionalEquality,' +
+					// 'OptionalMapUnusedValue,' +
+					// 'OptionalOfRedundantMethod,' +
+					// 'OptionalOrElseGet,' +
+					// 'OverlappingQualifierAndScopeAnnotation,' +
+					// 'OverridesJavaxInjectableMethod,' +
+					// 'PackageInfo,' +
+					// 'ParametersButNotParameterized,' +
+					// 'ParcelableCreator,' +
+					// 'PeriodFrom,' +
+					// 'PeriodGetTemporalUnit,' +
+					// 'PeriodTimeMath,' +
+					// 'PreconditionsInvalidPlaceholder,' +
+					// 'PrimitiveComparison,' +
+					// 'PrivateSecurityContractProtoAccess,' +
+					// 'ProtoBuilderReturnValueIgnored,' +
+					// 'ProtoStringFieldReferenceEquality,' +
+					// 'ProtoTruthMixedDescriptors,' +
+					// 'ProtocolBufferOrdinal,' +
+					// 'ProvidesMethodOutsideOfModule,' +
+					// 'RandomCast,' +
+					// 'RandomModInteger,' +
+					// 'RectIntersectReturnValueIgnored,' +
+					// 'RedundantSetterCall,' +
+					// 'RedundantStringConversion,' +
+					// 'RedundantStringEscape,' +
+					// 'RefasterAnyOfUsage,' +
+					// 'RequestMappingAnnotation,' +
+					// 'RequestParamType,' +
+					// 'RequiredModifiers,' +
+					// 'RestrictedApi,' +
+					// 'ReturnValueIgnored,' +
+					// 'SelfAssertion,' +
+					// 'SelfAssignment,' +
+					// 'SelfComparison,' +
+					// 'SelfEquals,' +
+					// 'SetUnrecognized,' +
+					// 'ShouldHaveEvenArgs,' +
+					// 'SizeGreaterThanOrEqualsZero,' +
+					// 'Slf4jLogStatement,' +
+					// 'Slf4jLoggerDeclarationSlf4jLoggerDeclaration,' +
+					// 'SpringMvcAnnotation,' +
+					'StaticImport,' +
+					// 'StreamToString,' +
+					// 'StringBuilderInitWithChar,' +
+					'StringJoin,'
+					// 'SubstringOfZero,' +
+					// 'SuppressWarningsDeprecated,' +
+					// 'TemporalAccessorGetChronoField,' +
+					// 'TestParametersNotInitialized,' +
+					// 'TheoryButNoTheories,' +
+					// 'ThreadBuilderNameWithPlaceholder,' +
+					// 'ThrowIfUncheckedKnownChecked,' +
+					// 'ThrowNull,' +
+					// 'TimeZoneUsage,' +
+					// 'TreeToString,' +
+					// 'TryFailThrowable,' +
+					// 'TypeParameterQualifier,' +
+					// 'UnicodeDirectionalityCharacters,' +
+					// 'UnicodeInCode,' +
+					// 'UnnecessaryCheckNotNull,' +
+					// 'UnnecessaryTypeArgument,' +
+					// 'UnsafeWildcard,' +
+					// 'UnusedAnonymousClass,' +
+					// 'UnusedCollectionModifiedInPlace,' +
+					// 'UnusedMethod,' +
+					// 'VarTypeName,' +
+					// 'WrongOneof,' +
+					// 'XorPower,' +
+					// 'ZoneIdOfZ,'
+					)
+		}
+	}
+}

lib-extra/src/cdt/java/com/diffplug/spotless/extra/glue/cdt/EclipseCdtFormatterStepImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2023 DiffPlug
+ * Copyright 2016-2025 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,10 +15,11 @@
  */
 package com.diffplug.spotless.extra.glue.cdt;
 
+import static java.util.stream.Collectors.toMap;
+
 import java.util.Map;
 import java.util.Map.Entry;
 import java.util.Properties;
-import java.util.stream.Collectors;
 import java.util.stream.Stream;
 
 import org.eclipse.cdt.core.formatter.CodeFormatter;
@@ -32,7 +33,7 @@ public class EclipseCdtFormatterStepImpl {
 
 	public EclipseCdtFormatterStepImpl(Properties settings) throws Exception {
 		Stream<Entry<Object, Object>> stream = settings.entrySet().stream();
-		Map<String, String> settingsMap = stream.collect(Collectors.toMap(
+		Map<String, String> settingsMap = stream.collect(toMap(
 				e -> String.valueOf(e.getKey()),
 				e -> String.valueOf(e.getValue())));
 		codeFormatter = org.eclipse.cdt.core.ToolFactory.createDefaultCodeFormatter(settingsMap);

lib-extra/src/groovy/java/com/diffplug/spotless/extra/glue/groovy/GrEclipseFormatterStepImpl.java

@@ -15,12 +15,13 @@
  */
 package com.diffplug.spotless.extra.glue.groovy;
 
+import static java.util.Collections.synchronizedList;
+
 import java.io.ByteArrayInputStream;
 import java.io.ByteArrayOutputStream;
 import java.io.IOException;
 import java.nio.file.Files;
 import java.util.ArrayList;
-import java.util.Collections;
 import java.util.List;
 import java.util.Map;
 import java.util.Properties;
@@ -111,7 +112,7 @@ public GroovyErrorListener() {
 			 * We need a synchronized list here, in case multiple instantiations
 			 * run in parallel.
 			 */
-			errors = Collections.synchronizedList(new ArrayList<>());
+			errors = synchronizedList(new ArrayList<>());
 			ILog groovyLogger = GroovyCoreActivator.getDefault().getLog();
 			groovyLogger.addLogListener(this);
 			synchronized (GroovyLogManager.manager) {

lib-extra/src/jdt/java/com/diffplug/spotless/extra/glue/jdt/EclipseJdtFormatterStepImpl.java

@@ -1,5 +1,5 @@
 /*
- * Copyright 2016-2024 DiffPlug
+ * Copyright 2016-2025 DiffPlug
  *
  * Licensed under the Apache License, Version 2.0 (the "License");
  * you may not use this file except in compliance with the License.
@@ -15,11 +15,12 @@
  */
 package com.diffplug.spotless.extra.glue.jdt;
 
+import static java.util.stream.Collectors.toMap;
+
 import java.io.File;
 import java.util.HashMap;
 import java.util.Map;
 import java.util.Properties;
-import java.util.stream.Collectors;
 
 import org.eclipse.jdt.core.formatter.CodeFormatter;
 import org.eclipse.jdt.internal.compiler.env.IModule;
@@ -37,7 +38,7 @@ public class EclipseJdtFormatterStepImpl {
 	private final EclipseJdtSortMembers.SortProperties sortProperties;
 
 	public EclipseJdtFormatterStepImpl(Properties formatterSettings, Map<String, String> sortProperties) {
-		Map<String, String> options = formatterSettings.entrySet().stream().collect(Collectors.toMap(
+		Map<String, String> options = formatterSettings.entrySet().stream().collect(toMap(
 				e -> String.valueOf(e.getKey()),
 				e -> String.valueOf(e.getValue()),
 				(prev, next) -> next,