Skip to content

tests: remove tests on all sub-projects? #46

@sbillinge

Description

@sbillinge

Problem

Now we are running the examples we don't need to run tests on the sub-packages, or vice versa.

Proposed solution

I think the reason to run all the sub-package tests is to test that everything is correctly installed, which is good. The examples also do that, so do we need them both?

Another thought is to not run all the example tests on each PR, but only on merge to main. The question is how we figure out whether it passed or not as we often don't check that. Can we add something to the merge to main action that sends a notification if it fails?

The lightest weight thing would be to just make some tests that resemble the examples and run each sub-package

tl;dr: I very much like that we run all the examples, but as a test of the examples, so we could make this workflow just run less often, on merge to main or just on dispatch? Running the tests of all the sub-packages is not a great test because it only tests that things that are installed are installed, not that things that should be installed are installed. the examples are better at that. Suggestion: examples test on merge to main, new test that is a kind of "mini" examples test replaces the "run all sub-packages tests" on PR.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions