replace danse links #202
Closed
replace danse links #202
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbillinge
reviewed
Aug 28, 2024
| @@ -1446,7 +1446,7 @@ the comments in the script for detailed explanation. | |||
| To learn more about the tui module and about the objects | |||
| and functions that it returns, please see the API | |||
| documentation for diffpy.pdfgui at | |||
| @url{http://docs.danse.us/diffraction/diffpy.pdfgui/}. | |||
| @url{https://www.diffpy.org/diffpy.pdfgui/api/diffpy.pdfgui.html}. | |||
There was a problem hiding this comment.
I think this should be https://diffpy.github.io/diffpy.pdfgui when everything is working, something like that. We don't want to resolve to a file on github but to published documentation.
There was a problem hiding this comment.
Thanks, will change, also see discussion in #203
|
@Tieqiong when you have time, please could you revisit this one and we can get it merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #186