fix: buggy test click button url #255
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge please check, thanks
This is not a fix on the actual code. This is for fixing a buggy test code (bug on test code not on the actual code) that fails all the windows matrix test.
The problem is on
test_LogoClicks
intest_aboutdialog.py
. This test is to simulate user interactions with theAbout
tag in GUI and verify clicking on various logo buttons leads to the expected url. The modified context manageroverridewebbrowser
is in testutils but used intest_LogoClicks
. It try to temporarily replaces the normal behavior of opening a web browser by callingset_url
which captures the url thatpdfgui
tries to open without actually opening the browser.The reason why the test was not passing only on Windows is because
webbrowser.open
work differently on windows, which returns different instance for subsequent calls. Thus the override in the old test code doesn't stick to the right instance as the code that actually callswebbrowser.open
ends up using a different unchangedcontroller
.