function reconsturct_data #50
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
There is already a function named |
sbillinge
reviewed
Aug 14, 2023
| number_of_signal = len(components[0].weights) | ||
| data_reconstruction = np.zeros((signal_length, number_of_signal)) | ||
| for signal in range(number_of_signal): | ||
| data_reconstruction[:, signal] = reconstruct_signal(components, signal) |
There was a problem hiding this comment.
as before, is there a reason the nd array is this way around and the code can't look like can't be:
data_reconstruction[signal] = reconstruct_signal(components, signal)
to make the code prettier?
There was a problem hiding this comment.
Other functions use what this function returns later. It's possible that I could make it the other way here, and transpose the output when it is used.
There was a problem hiding this comment.
This function is ready to be merged. Unless you think that I should rewrite this line in the way that you suggested.
removed blank lines in tests
|
Thanks Ade |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.