fix: complete dependencies #45
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Tieqiong can we have a quick chat about this? In general, we may want to think about how we want to handle this. |
|
I will merge this to continue the cookiecutting, but have made an issue to revisit after our discussions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbillinge This still needs some discussion.
objcrystsupport will not be activated iflibdiffpyisn't complied withlibobjcryst, but iflibdiffpyis complied withlibobjcrystthenlibobjcryst(and of courselibdiffpy) will also be a build dependency ofdiffpy.srreal.pyobjcrystis also needed fordiffpy.srreal(built withlibobjcryst), which has weird conda install conflicts for me even if it's up to py3.13. It can be installed for py3.11.periodictableis a pure python optional run dependency.