Skip to content

Conversation

cadenmyers13
Copy link
Contributor

@cadenmyers13 cadenmyers13 commented Jun 18, 2025

Ran pre-commit and these are the autofixes from isort and flake8 line length. This will fail flake8 because of linelength. Ill do manual edits on another PR.

@cadenmyers13
Copy link
Contributor Author

@Tieqiong I'm getting this failure. Do you know why?

Screenshot 2025-06-18 at 11 01 28 AM

@Tieqiong
Copy link
Contributor

@cadenmyers13 I don't have access so I can't make changes directly into this PR. Let's use Mac instead of Linux for now. Simply go to test-on-pr.yml, line 17 change

    runs-on: ubuntu-latest

to

    runs-on: macos-14

and tests should pass

@cadenmyers13
Copy link
Contributor Author

@Tieqiong great, thanks!

@sbillinge sbillinge merged commit a1420e4 into diffpy:cookie Jun 20, 2025
1 of 2 checks passed
@cadenmyers13 cadenmyers13 deleted the pre-commit-auto branch June 23, 2025 14:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants