Skip to content

Conversation

ycexiao
Copy link
Contributor

@ycexiao ycexiao commented Jul 30, 2025

What problem does this PR address?

Closes #62

What should the reviewer(s) do?

Please check the rendered documentation.
image
image
image

Copy link
Contributor Author

@ycexiao ycexiao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sbillinge, it's ready for review.

:undoc-members:
:show-inheritance:

Subpackages
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is only one folder devutils inside src/diffpy/srreal. But in diffpy.structure, this folder is not in the src folder. Do we want to build an API page for this package?

@ycexiao ycexiao marked this pull request as ready for review July 30, 2025 00:48
@sbillinge sbillinge changed the base branch from main to migration July 30, 2025 01:59
@sbillinge
Copy link
Contributor

I changed the base to migration just in case.

Srreal code is mostly c-code so it may not build very rich API docs. @Tieqiong do you know a way to build API docs from c-code drilling down through python wrappers?

@sbillinge
Copy link
Contributor

@ycexiao @zmx27 at the least we would like the docs to have as much informatoin as in the original docs if we can find a link to them. There are some simple docstrings in the python wrappers. I didn't check the c code to see if there are any docstring like things in there.

@sbillinge
Copy link
Contributor

here is the link to the original docs: https://pyobjcryst.readthedocs.io/en/latest/

@sbillinge
Copy link
Contributor

We can have a conversation with Vincent about what style to use (conform to diffpy standards or to pyobj legacy) but it would be nice if we could figure it out for the docs to build and deploy automatically using our workflows. We may need to sort out whether it will finally deploy to readthedocs or gh-pages.

@sbillinge
Copy link
Contributor

We can have a conversation with Vincent about what style to use (conform to diffpy standards or to pyobj legacy) but it would be nice if we could figure it out for the docs to build and deploy automatically using our workflows. We may need to sort out whether it will finally deploy to readthedocs or gh-pages.

sorry, this refers to pyobjcryst not srreal

@sbillinge
Copy link
Contributor

I will merge this. Please could we make an issue (and work on) the devutils issue. I would like to understand what it does and how to handle it. Not a big job, just 30 minutes of digging around.

@sbillinge sbillinge merged commit 8f68bf6 into diffpy:migration Jul 30, 2025
14 checks passed
@Tieqiong
Copy link
Contributor

Tieqiong commented Aug 1, 2025

I changed the base to migration just in case.

Srreal code is mostly c-code so it may not build very rich API docs. @Tieqiong do you know a way to build API docs from c-code drilling down through python wrappers?

@sbillinge sorry missed this. Yes! and let's have this conversation at pyobjcryst.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

doc: fix package API building to comply with scikit-package 0.1.0 standards
3 participants