-
Notifications
You must be signed in to change notification settings - Fork 23
docs: fix documentation rendering #66
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sbillinge, it's ready for review.
:undoc-members: | ||
:show-inheritance: | ||
|
||
Subpackages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There is only one folder devutils
inside src/diffpy/srreal
. But in diffpy.structure
, this folder is not in the src
folder. Do we want to build an API page for this package?
I changed the base to migration just in case. Srreal code is mostly c-code so it may not build very rich API docs. @Tieqiong do you know a way to build API docs from c-code drilling down through python wrappers? |
here is the link to the original docs: https://pyobjcryst.readthedocs.io/en/latest/ |
We can have a conversation with Vincent about what style to use (conform to diffpy standards or to pyobj legacy) but it would be nice if we could figure it out for the docs to build and deploy automatically using our workflows. We may need to sort out whether it will finally deploy to readthedocs or gh-pages. |
sorry, this refers to pyobjcryst not srreal |
I will merge this. Please could we make an issue (and work on) the devutils issue. I would like to understand what it does and how to handle it. Not a big job, just 30 minutes of digging around. |
@sbillinge sorry missed this. Yes! and let's have this conversation at pyobjcryst. |
What problem does this PR address?
Closes #62
What should the reviewer(s) do?
Please check the rendered documentation.


