Skip to content

Conversation

Tieqiong
Copy link
Contributor

@Tieqiong Tieqiong commented Aug 1, 2025

@sbillinge please check, thanks

update setup.py for wheel build
update deprecated calls from objcryst.crystal, closes #50
correct fixture typos...
correct pip.txt
add version fallback

correct function name typos
correct pip.txt
add version fallback
@Tieqiong
Copy link
Contributor Author

Tieqiong commented Aug 1, 2025

Why we want to use matrix test for PR here?

@sbillinge
Copy link
Contributor

Why we want to use matrix test for PR here?

haha, you did that at some point. Let's turn it off and just do a linux build, at least for tests_on_pr, (good to keep the matrix build on merge to main?) now we have all the platform builds working, so we are just checking that new code doesn't break any code logic.

@sbillinge sbillinge merged commit 61269cd into diffpy:migration Aug 1, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants