EE Fix/support management repo policies #1588
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
UtpalJayNadiger
approved these changes
Jun 24, 2024
opp-svega
reviewed
Jun 28, 2024
| BackendApi = backend.NewBackendApi(hostName, token) | ||
| PolicyChecker = policy.NewPolicyChecker(hostName, orgName, token) | ||
| //PolicyChecker = policy.NewPolicyChecker(hostName, orgName, token) |
There was a problem hiding this comment.
Commenting this out breaks the policy checker
19:29:25 github.go:344: - root
19:29:25 github.go:346: GitHub event processed successfully
19:29:25 github.go:378: GitHub event converted to commands successfully
19:29:25 github.go:439: Following commands are going to be executed:
project: root: commands: "digger plan",
19:29:25 policy.go:272: Error while fetching policy: unexpected response while fetching project policy: Not allowed to access this resource with this access level code 403
19:29:25 usage.go:112: Failed to run commands. error checking policy: unexpected response while fetching project policy: Not allowed to access this resource with this access level code 403```
There was a problem hiding this comment.
Hey! We have moved the logic of fetching policy checkers to providers: https://github.com/diggerhq/digger/pull/1588/files#diff-476bae6fdca0f01c3e01eb49e676ec25f2de056f623d578aa8eb03b35940376bR12
Thats why it has been commented out from here , because its passed as a provider into the function: https://github.com/diggerhq/digger/pull/1588/files#diff-df1410c7e541e1f284e5260de3e777131a5ca5283fa4b8f36a03dfc5de9b2f29R27
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.