Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adding logic to validate if the PR must get merged #183

Merged
merged 3 commits into from
May 2, 2023
Merged

fix: adding logic to validate if the PR must get merged #183

merged 3 commits into from
May 2, 2023

Conversation

fleroux514
Copy link
Contributor

@fleroux514 fleroux514 commented Apr 29, 2023 •
edited
Loading

Added validation:

  • check if apply comment along with auto_merge config before trying to merge the PR
  • check if a requested project name was specified in the comment, and if the PR impacts more than one project (in which case we don't want to merge)

@fleroux514 fleroux514 marked this pull request as draft April 29, 2023 13:00
@fleroux514 fleroux514 force-pushed the fix/auto-merge-config branch 2 times, most recently from 8cde9fb to 26122a9 Compare May 1, 2023 02:42
@fleroux514 fleroux514 changed the title fix: check if apply comment along with auto_merge config before trying to merge the PR fix: adding more logic to vaidate if the PR must get merged May 1, 2023
@fleroux514 fleroux514 changed the title fix: adding more logic to vaidate if the PR must get merged fix: adding logic to validate if the PR must get merged May 1, 2023
@fleroux514 fleroux514 marked this pull request as ready for review May 1, 2023 03:29
veziak
veziak approved these changes May 2, 2023
View reviewed changes
Copy link
Contributor

@veziak veziak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@veziak veziak merged commit c7b3047 into main May 2, 2023
@veziak veziak deleted the fix/auto-merge-config branch May 2, 2023 11:24
ben-of-codecraft pushed a commit to ben-of-codecraft/digger that referenced this pull request May 21, 2024
@veziak
Merge pull request diggerhq#183 from diggerhq/fix/auto-merge-config
1c5d01c 
fix: adding logic to validate if the PR must get merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@veziak veziak veziak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fleroux514 @veziak