Added support to verify all signatures in a SAML message by using the… #161
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kevintuhumury
force-pushed
the
verify-multiple-signatures-with-corresponding-key-names
branch
from
8d37d9c to
ece3474
Compare
… corresponding KeyName instead of the KeyName of the first signature it finds in a SAML message. - Added a new set of key and certificate. - Added the new certificate as a signing certificate to the metadata of the Service Provider fixture. - Created a new fixture which contains an AuthnRequest signed with the newly added signing key (a) and added that AuthnRequest to an ArtifactResponse which is signed with the existing signing key (b), which both belong to the Service Provider. - Added functionality to support the verification of multiple signatures signed by a single issuer using multiple signing keys. - Verified that the resulting XML is valid. Added the requirement that Nokogiri 1.8.5 or lower should be used. Nokogiri 1.9.0 and 1.9.1 (released during the last two days) cause a lot of errors on JRuby with the current master branch (so, even without these changes).
kevintuhumury
force-pushed
the
verify-multiple-signatures-with-corresponding-key-names
branch
from
ece3474 to
2dbed14
Compare
kevintuhumury
deleted the
verify-multiple-signatures-with-corresponding-key-names
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… corresponding KeyName instead of the KeyName of the first signature it finds in a SAML message.