optionally include SP certificate in encrypted assertions #166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, Yeah if you could make it optional, that would be great. |
nov
force-pushed
the
feature/include_certificate_in_encrypted_assertion
branch
from
b3a8086 to
90fc1e7
Compare
nov
changed the title
|
Hi @benoist, Thanks for your super fast review. |
|
@nov It's released to 3.6.0 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, one of my client's SP requires SP certificate in the response's encrypted assertion.
I've added it and updated related specs.
ps.
This change increase the response size a bit.
If you don't like it, I can make the certificate optional.