Skip to content

Conversation

truongnmt
Copy link
Contributor

@truongnmt truongnmt commented Mar 12, 2020

Motivation

In my use case, AuthnRequest doesn't need to be signed.
Our IdP is Azure which said the following:
https://docs.microsoft.com/en-us/azure/active-directory/develop/single-sign-on-saml-protocol#signature

Signature
Don't include a Signature element in AuthnRequest elements, as Azure AD does not support signed authentication requests.

Besides, by making AuthnRequest optional, when adding service-provider to provider store, we don't need to specify a signing key.

Relate issues

#168 (comment)

Changes

  • Added instance variable exclude_signature, defined by options[:exclude_signature]
  • Existing applications which are not specifying this option will run as usual (sign AuthnRequest and add Signature, SigAlg params in AuthnRequest URL)
  • Will not sign and add Signature, SigAlg params in AuthnRequest URL if specify exclude_signature = true

Usage:

Saml::Bindings::HTTPRedirect.create_url(authn_request, exclude_signature: true)

@coveralls
Copy link

coveralls commented Mar 12, 2020

Coverage Status

Coverage increased (+8.0e-05%) to 99.848% when pulling b300377 on truongnmt:feat/make-authn-request-signature-optional into e2d3e12 on digidentity:master.

@truongnmt truongnmt marked this pull request as ready for review March 12, 2020 05:46
@truongnmt
Copy link
Contributor Author

@benoist Can you please have a look? Thanks!

@benoist benoist merged commit 803dedd into digidentity:master Mar 17, 2020
@truongnmt truongnmt deleted the feat/make-authn-request-signature-optional branch March 18, 2020 02:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants