Skip to content

Fix UnparseableMessage exception when xml is nil #29

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Nov 2, 2018
Merged

Fix UnparseableMessage exception when xml is nil #29

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/xmlenc/builder/base.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,7 @@ def from_xml?

module XmlMapperClassMethods
def parse(xml, options = {})
raise Xmlenc::UnparseableMessage("Unable to parse nil document") if xml.nil?
raise Xmlenc::UnparseableMessage.new("Unable to parse nil document") if xml.nil?

object = super
if object.is_a?(Array)
Expand Down
2 changes: 1 addition & 1 deletion spec/lib/xmlenc/builder/base_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ class BaseDummy
it "raises an error if the message is nil" do
expect {
BaseDummy.parse(nil)
}.to raise_error(Xmlenc::UnparseableMessage)
}.to raise_error(Xmlenc::UnparseableMessage, 'Unable to parse nil document')
end
end
end