Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DAML Engine does not check that key maintainers are signatories #1123

Closed
hurryabit opened this issue May 14, 2019 · 3 comments
Closed

DAML Engine does not check that key maintainers are signatories #1123

hurryabit opened this issue May 14, 2019 · 3 comments
Labels
broken Product is broken and must be fixed component/daml-engine DAML-LF Engine & Interpreter
Milestone
runtime/backlog

Comments

@hurryabit
Copy link
Contributor

The following scenario passes even though it shouldn't:

template Foo with
    p : Party
    q : Party
  where
    signatory p
    key (p, q) : (Party, Party)
    maintainer q

test = scenario do
  p <- getParty "P"
  q <- getParty "Q"
  submit p do
    create Foo with ..
@hurryabit hurryabit added broken Product is broken and must be fixed component/daml-engine DAML-LF Engine & Interpreter labels May 14, 2019
@hurryabit
Copy link
Contributor Author

daml/daml-lf/interpreter/src/main/scala/com/digitalasset/daml/lf/types/Ledger.scala

Line 702 in ed431b4

know that `maintainers ⊆ stakeholders`, since `maintainers ⊆

The reasoning at this point is related to this issue.

bitonic added a commit that referenced this issue May 14, 2019
@bitonic
check that maintainers are a subset of signatories
79b1e9b 
fixes #1123
bitonic added a commit that referenced this issue May 14, 2019
@bitonic
check that maintainers are a subset of signatories
8368c4b 
fixes #1123
bitonic added a commit that referenced this issue May 21, 2019
@bitonic
check that maintainers are a subset of signatories
7fe4887 
fixes #1123
bitonic added a commit that referenced this issue May 21, 2019
@bitonic
check that maintainers are a subset of signatories
8e61cc2 
fixes #1123
mergify bot pushed a commit that referenced this issue May 21, 2019
@bitonic @mergify
Maintainers must be signatories (#1124)
95e8dd0 
* check that maintainers are a subset of signatories

fixes #1123

* add note on why `fetchByKey` gets you the contract data
@gerolf-da
Copy link
Contributor

This should have been fixed by #1124.

@gerolf-da gerolf-da added this to the Runtime Backlog milestone Feb 14, 2020
@stefanobaghino-da
Copy link
Contributor

This should have been fixed by #1124.

Sounds about right. Can we close this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
broken Product is broken and must be fixed component/daml-engine DAML-LF Engine & Interpreter
Projects
None yet
Milestone
runtime/backlog
Development

No branches or pull requests
4 participants
@bitonic @hurryabit @gerolf-da @stefanobaghino-da