Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DAML Engine does not check that key maintainers are signatories #1123

Open
hurryabit opened this issue May 14, 2019 · 1 comment

Comments

Projects
None yet
2 participants
@hurryabit
Copy link
Contributor

commented May 14, 2019

The following scenario passes even though it shouldn't:

template Foo with
    p : Party
    q : Party
  where
    signatory p
    key (p, q) : (Party, Party)
    maintainer q

test = scenario do
  p <- getParty "P"
  q <- getParty "Q"
  submit p do
    create Foo with ..
@hurryabit

This comment has been minimized.

Copy link
Contributor Author

commented May 14, 2019

know that `maintainers ⊆ stakeholders`, since `maintainers ⊆

The reasoning at this point is related to this issue.

mergify bot added a commit that referenced this issue May 21, 2019

Maintainers must be signatories (#1124)
* check that maintainers are a subset of signatories

fixes #1123

* add note on why `fetchByKey` gets you the contract data
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.