Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ledger api server: Standalone indexer escaping / dropping of participantId special chars in actor system name #3327

Closed
oliverse-da opened this issue Nov 4, 2019 · 1 comment · Fixed by #3359 or #3604
Closed

Ledger api server: Standalone indexer escaping / dropping of participantId special chars in actor system name #3327

oliverse-da opened this issue Nov 4, 2019 · 1 comment · Fixed by #3359 or #3604
Assignees
@oliverse-da
Labels
component/ledger Sandbox and Ledger API multi-domain Pertaining to multi-domain ledger integration
Milestone
runtime/backlog

Comments

@oliverse-da
Copy link
Contributor

In StandaloneIndexerServer

-    val actorSystem                    = ActorSystem(config.participantId)
+    val actorSystem                    = ActorSystem("StandaloneIndexerServer-" + config.participantId.filterNot(".:#/ ".toSet))
@oliverse-da oliverse-da added component/ledger Sandbox and Ledger API multi-domain Pertaining to multi-domain ledger integration labels Nov 4, 2019
@oliverse-da oliverse-da added this to the Backlog milestone Nov 4, 2019
@oliverse-da oliverse-da self-assigned this Nov 4, 2019
oliverse-da added a commit that referenced this issue Nov 6, 2019
@oliverse-da
Allow ledger api server participant ids with LedgerString chars
457b471 
Closes #3327
@oliverse-da oliverse-da mentioned this issue Nov 6, 2019
Merged
6 tasks
oliverse-da added a commit that referenced this issue Nov 7, 2019
@oliverse-da
Allow ledger api server participant ids with LedgerString chars
f1c93c7 
Closes #3327
oliverse-da added a commit that referenced this issue Nov 7, 2019
@oliverse-da
Allow ledger api server participant ids with LedgerString chars
4a291ac 
Closes #3327
oliverse-da added a commit that referenced this issue Nov 7, 2019
@oliverse-da
Allow ledger api server participant ids with LedgerString chars
f39bf7f 
Closes #3327
oliverse-da added a commit that referenced this issue Nov 7, 2019
@oliverse-da
Multi domain ledger api server fixes (#3359)
0df351b 
* Divulged contract visibility in multi-participant environments #3351
* Ledger api server time service optional ability for testing #3225
* Allow ledger api server to share DAML-on-X DAML engine #2975
* Allow ledger api server participant ids with LedgerString chars #3327
* Ledger api server includes SQL description in errors #3324
@oliverse-da oliverse-da changed the title Ledger api server: Standalone indexer escaping / droppping of participantId special chars in actor system name Ledger api server: Standalone indexer escaping / dropping of participantId special chars in actor system name Nov 18, 2019
@oliverse-da oliverse-da reopened this Nov 18, 2019
@oliverse-da
Copy link
Contributor Author

The UrlEncode approach puts '%' characters in the actor name which is not allowed either. Switch to the approach originally described in the description above.

@oliverse-da oliverse-da mentioned this issue Nov 25, 2019
Merged
6 tasks
oliverse-da added a commit that referenced this issue Nov 25, 2019
@oliverse-da
Properly drop invalid actor name chars in standalone indexer actor name
1a78582 
Closes #3327

CHANGELOG_BEGIN

[Ledger]
  * Allow non-alphanumeric characters in ledger api server participant ids (space, colon, hash, slash, dot). Proper fix for change originally attempted in v0.13.36. See issue `issue #3327 <https://github.com/digital-asset/daml/issues/3327>`__.

CHANGELOG_END

Proper fix replacing f39bf7f which does not work
@mergify mergify bot closed this as completed in #3604 Nov 25, 2019
mergify bot pushed a commit that referenced this issue Nov 25, 2019
@oliverse-da @mergify
Properly drop invalid actor name chars in standalone indexer actor na…
26b569f 
…me (#3604)

Closes #3327

CHANGELOG_BEGIN

[Ledger]
  * Allow non-alphanumeric characters in ledger api server participant ids (space, colon, hash, slash, dot). Proper fix for change originally attempted in v0.13.36. See issue `issue #3327 <https://github.com/digital-asset/daml/issues/3327>`__.

CHANGELOG_END

Proper fix replacing f39bf7f which does not work
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oliverse-da oliverse-da

Labels
component/ledger Sandbox and Ledger API multi-domain Pertaining to multi-domain ledger integration
Projects
None yet
Milestone
runtime/backlog
1 participant
@oliverse-da