Refactor trigger rule simulation lib #16645
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
carlpulley-da
commented
Apr 1, 2023
|
|
||
| trait CatGenerators { | ||
|
|
||
| protected def packageId: PackageId |
There was a problem hiding this comment.
We allow call/use sites to set the package ID
carlpulley-da
commented
Apr 1, 2023
| applicationId, | ||
| triggerParties, | ||
| ) | ||
| class SimulationContext { |
There was a problem hiding this comment.
SimulationContext allows core state to be used on a per test basis
carlpulley-da
commented
Apr 1, 2023
| @@ -63,20 +50,6 @@ class TriggerRuleSimulationLibTest | |||
| .copy(allowTriggerTimeouts = true, allowInFlightCommandOverflows = true) | |||
| ) | |||
|
|
|||
| def forAll[T](gen: Gen[T], sampleSize: Int = 100, parallelism: Int = 1)( | |||
There was a problem hiding this comment.
Moved into TriggerRuleSimulationLib for reuse elsewhere
10 tasks
Comment on lines
+48
to
+49
| private[this] val metricCountData = mutable.Map.empty[Set[UUID], mutable.Map[String, Long]] | ||
| private[this] val metricTimingData = |
There was a problem hiding this comment.
I did not notice that before but why are we using a mutable data structure here.
There was a problem hiding this comment.
Discussed this point offline and have decided to not alter the code here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor trigger rule simulation library as follows:
TriggerRuleSimulationso that code can be ran on async workloads (useful for trigger resource and multi-process trigger simulation tests)CatGeneratorsinto a trait so that they may be reused across tests (again useful for trigger resource and multi-process simulation tests)