Skip to content
This repository was archived by the owner on May 28, 2022. It is now read-only.

Conversation

msporny
Copy link
Member

@msporny msporny commented Feb 18, 2017

Please check to make sure I implemented get/setActiveGroup correctly.

@dlongley
Copy link
Member

This seems like it's application specific -- not a general feature. Is that true? Is there another way we can get some support code in here for what you're trying to do in a more generic way?

Also, the information isn't going into the session on the server at all -- it's just a client-side thing. I would expect that if we did anything client-side, it would be done perhaps as a cache? I'm a little confused about this PR in general, I suppose.

@msporny
Copy link
Member Author

msporny commented Mar 2, 2017

@dlongley said:

This seems like it's application specific -- not a general feature. Is that true? Is there another way we can get some support code in here for what you're trying to do in a more generic way?

Setting and getting the active group is now a general feature... Bedrock supports it. Using the feature is application specific and is usually performed on login/logout. For applications that need groups, they will add the group and set the default group on login if it's not already set. For applications that don't need groups, they won't call these APIs.

@dlongley said:

Also, the information isn't going into the session on the server at all -- it's just a client-side thing. I would expect that if we did anything client-side, it would be done perhaps as a cache? I'm a little confused about this PR in general, I suppose.

Session information available via AngularJS is a combination of information on the back-end and information that is cached on the front-end. If we don't use this approach, the developer has to juggle a new concept, which is "client-side session information" and "server-side session information", which seems like unnecessary complexity.

@mattcollier
Copy link
Contributor

@dlongley @msporny It would be good to get this PR handled as we look towards our ES6 release cycle.

@dlongley dlongley removed their request for review June 6, 2021 19:09
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants