Support JSON literals.

[davidlehn]

work-in-progress.

[gkellogg]

@davidlehn I did some work on expansion use cases, compaction and everything else seems to work okay already. See what you think.

[dlongley]

Approving but left some comments for tidying a few things up.

[davidlehn]

I'm not sure what the guarantees of that json-canonicalize code are. It depends on the native JSON.stringify. Do we need some runtime test (maybe from the jcs browser tests) to know if the native code works as expected? The concern is if this code runs on ye olde browser or odd runtime and the JSON.stringify output differs.

[dlongley]

@davidlehn,

It depends on the native JSON.stringify. Do we need some runtime test (maybe from the jcs browser tests) to know if the native code works as expected?

Sounds like we should add some canonicalization tests over here for that: https://github.com/json-ld/normalization

[gkellogg]

@davidlehn,

It depends on the native JSON.stringify. Do we need some runtime test (maybe from the jcs browser tests) to know if the native code works as expected?

Sounds like we should add some canonicalization tests over here for that: https://github.com/json-ld/normalization

The code is right out of the RFC example. There's also an NPM Package referenced from the spec to implement this. If you use a package which is tested, I'm not sure what the merits of re-testing are.

[davidlehn]

@gkellogg I may be misunderstanding, but I think the algorithm and code depends on an ES6 runtime? I thought there were some issues if you use older browsers where some behavior was not yet standardized. Am I mistaken on that point? I'm just wondering how/if we can detect that so we don't output garbage by mistake if someone runs the code on an old platform.

Also I forgot that code was in the RFC. Should use that vs the code from the repo. I also didn't realize that package existed. NPM search failed me. Maybe we should just use that.

[davidlehn]

From the RFC "JCS relies on serialization of JSON primitives compatible with ECMAScript (aka JavaScript) beginning with version 6". How do we check, support, or error out on pre-ES6 serializers?

[davidlehn]

I'm not sure what the best way to detect that the native serializer does what it's supposed to do. The limited JCS tests appear to run on Node.js 4-12, IE11, and recent Edge, Firefox, Safari, and Chromium. So we'll call that good enough for now.