misc task cleanup

src/main/java/ch/digitalfondue/stampo/processor/DirPaginator.java

@@ -153,7 +153,6 @@ private List<PathAndModelSupplier> handleContentDir(FileResource resource, Local
     return toAdd;
   }
 
-  //TODO: apply filter
   private List<PathAndModelSupplier> handleStaticDir(FileResource resource, Path defaultOutputPath,
       DirPaginationConfiguration dirPaginationConf, Path targetDirPath) throws IOException {
     Comparator<Path> comparator = Comparator.comparing((Path p) -> p.getFileName().toString(),//

src/main/java/ch/digitalfondue/stampo/resource/FileResource.java

@@ -18,7 +18,6 @@
 
 import java.util.ArrayList;
 import java.util.Arrays;
-import java.util.Collections;
 import java.util.Date;
 import java.util.List;
 import java.util.Optional;
@@ -34,24 +33,22 @@ public interface FileResource extends Resource {
   StructuredFileExtension getStructuredFileExtension();
 
   /**
-   * File extensions, ordered last to first.
+   * File extensions
    * 
    * E.g.
    * 
    * <pre>
    * - test -> []
    * - test.txt -> [txt]
-   * - test.txt.peb -> [peb, txt]
-   * - test.en.txt.peb -> [peb, txt, en]
+   * - test.txt.peb -> [txt, peb]
+   * - test.en.txt.peb -> [en, txt, peb]
    * </pre>
    * 
    * */
   default List<String> getFileExtensions() {
     String fileName = getPath().getFileName().toString();
     String extensions = fileName.substring(getFileNameWithoutExtensions().length());
-    List<String> exts = Arrays.stream(extensions.split("\\.")).filter(s->s.length() > 0).collect(Collectors.toCollection(ArrayList::new));
-    Collections.reverse(exts);
-    return Collections.unmodifiableList(exts);
+    return Arrays.stream(extensions.split("\\.")).filter(s->s.length() > 0).collect(Collectors.toCollection(ArrayList::new));
   }
 
   default String getFileNameWithoutExtensions() {

src/main/java/ch/digitalfondue/stampo/resource/FileResourceWithMetadataSection.java

@@ -140,11 +140,11 @@ private Content readContent(ReadMode mode) {
       throw new IllegalStateException(ioe);
     }
   }
-
-  // TODO: check possible inconsistency with FileResource.containLocaleInFileExtensions 
+
   /* given a list of extensions, return a structured view */
   private StructuredFileExtension classifyFileExtension(Path filePath) {
     List<String> exts = getFileExtensions();
+    Collections.reverse(exts);
     //
 
     List<String> processorRelated = takeWhile(exts, configuration.getProcessorResourceExtensions()::contains);

src/main/java/ch/digitalfondue/stampo/resource/StaticFileResource.java

@@ -32,7 +32,6 @@ public StaticFileResource(StampoGlobalConfiguration configuration, Path path, Re
     this.configuration = configuration;
     this.path = path;
     this.parent = parent;
-    //TODO: check if order of the rest list is correct
     this.structuredFileExtension = new StructuredFileExtension(Collections.emptyList(), Optional.empty(), Optional.empty(), Collections.emptySet(), getFileExtensions());
   }