-
Notifications
You must be signed in to change notification settings - Fork 41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add no_auth option (Fixes #67) #79
Add no_auth option (Fixes #67) #79
Conversation
This reverts commit 3211359.
I just added a note to the README, assuming that the next |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍 Great work! Thanks so much for seeing this through across multiple projects!
[![Mend Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com) This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [digitalocean/action-doctl](https://togithub.com/digitalocean/action-doctl) | action | minor | `v2.4.1` -> `v2.5.0` | --- ### Release Notes <details> <summary>digitalocean/action-doctl (digitalocean/action-doctl)</summary> ### [`v2.5.0`](https://togithub.com/digitalocean/action-doctl/releases/tag/v2.5.0) [Compare Source](https://togithub.com/digitalocean/action-doctl/compare/v2.4.1...v2.5.0) #### What's Changed - Add no_auth option (Fixes [#​67](https://togithub.com/digitalocean/action-doctl/issues/67)) by [@​trinitronx](https://togithub.com/trinitronx) in [https://github.com/digitalocean/action-doctl/pull/79](https://togithub.com/digitalocean/action-doctl/pull/79) #### New Contributors - [@​trinitronx](https://togithub.com/trinitronx) made their first contribution in [https://github.com/digitalocean/action-doctl/pull/79](https://togithub.com/digitalocean/action-doctl/pull/79) **Full Changelog**: digitalocean/action-doctl@v2.4.1...v2.5.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about this update again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Mend Renovate](https://www.mend.io/free-developer-tools/renovate/). View repository job log [here](https://developer.mend.io/github/Johannes-Andersen/Johannes). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==--> Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@andrewsomething: Thanks & you're most welcome! 😀 Next steps are to wait for |
As a followup to digitalocean/doctl#1450, this PR adds a
no_auth
option to this GitHub Action. This pull request if merged will fix #67 by making thetoken
parameter optional whenno_auth: true
is passed.Notes: My work on this PR was done as part of DigitalOcean + MLH's Hacktoberfest + Global Hack Week: Open Source.
By the way, I think that there are 2 tags required for the Hacktoberfest profile page to qualify a PR for credit towards Hacktoberfest:
Hacktoberfest
: For a PR to show up in the list of participating project PRsHacktoberfest-accepted
: When the PR is acceptedThe one for digitalocean/doctl#1450 still isn't shown as participating on that page when I checked today.