Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add no_auth option (Fixes #67) #79

Merged
merged 6 commits into from
Oct 25, 2023

Conversation

trinitronx
Copy link
Contributor

@trinitronx trinitronx commented Oct 25, 2023

As a followup to digitalocean/doctl#1450, this PR adds a no_auth option to this GitHub Action. This pull request if merged will fix #67 by making the token parameter optional when no_auth: true is passed.

Notes: My work on this PR was done as part of DigitalOcean + MLH's Hacktoberfest + Global Hack Week: Open Source.

By the way, I think that there are 2 tags required for the Hacktoberfest profile page to qualify a PR for credit towards Hacktoberfest:

  • Hacktoberfest: For a PR to show up in the list of participating project PRs
  • Hacktoberfest-accepted: When the PR is accepted

The one for digitalocean/doctl#1450 still isn't shown as participating on that page when I checked today.

@trinitronx
Copy link
Contributor Author

I just added a note to the README, assuming that the next doctl SemVer release would be a feature version bump. Feel free to change it if that assumption is not correct (e.g. if the next future version is v1.100.1).

Copy link
Member

@andrewsomething andrewsomething left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Great work! Thanks so much for seeing this through across multiple projects!

@andrewsomething andrewsomething merged commit e5cb5b0 into digitalocean:v2 Oct 25, 2023
8 checks passed
renovate bot referenced this pull request in Johannes-Andersen/Johannes Oct 25, 2023
[![Mend
Renovate](https://app.renovatebot.com/images/banner.svg)](https://renovatebot.com)

This PR contains the following updates:

| Package | Type | Update | Change |
|---|---|---|---|
|
[digitalocean/action-doctl](https://togithub.com/digitalocean/action-doctl)
| action | minor | `v2.4.1` -> `v2.5.0` |

---

### Release Notes

<details>
<summary>digitalocean/action-doctl (digitalocean/action-doctl)</summary>

###
[`v2.5.0`](https://togithub.com/digitalocean/action-doctl/releases/tag/v2.5.0)

[Compare
Source](https://togithub.com/digitalocean/action-doctl/compare/v2.4.1...v2.5.0)

#### What's Changed

- Add no_auth option (Fixes
[#&#8203;67](https://togithub.com/digitalocean/action-doctl/issues/67))
by [@&#8203;trinitronx](https://togithub.com/trinitronx) in
[https://github.com/digitalocean/action-doctl/pull/79](https://togithub.com/digitalocean/action-doctl/pull/79)

#### New Contributors

- [@&#8203;trinitronx](https://togithub.com/trinitronx) made their first
contribution in
[https://github.com/digitalocean/action-doctl/pull/79](https://togithub.com/digitalocean/action-doctl/pull/79)

**Full Changelog**:
digitalocean/action-doctl@v2.4.1...v2.5.0

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined),
Automerge - At any time (no schedule defined).

🚦 **Automerge**: Enabled.

♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the
rebase/retry checkbox.

🔕 **Ignore**: Close this PR and you won't be reminded about this update
again.

---

- [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check
this box

---

This PR has been generated by [Mend
Renovate](https://www.mend.io/free-developer-tools/renovate/). View
repository job log
[here](https://developer.mend.io/github/Johannes-Andersen/Johannes).

<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4zMS41IiwidXBkYXRlZEluVmVyIjoiMzcuMzEuNSIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->

Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com>
@trinitronx
Copy link
Contributor Author

trinitronx commented Oct 26, 2023

👍 Great work! Thanks so much for seeing this through across multiple projects!

@andrewsomething: Thanks & you're most welcome! 😀

Next steps are to wait for doctl v1.101.0, then use the merged code in... you guessed it... even more projects! 🤣

@trinitronx trinitronx deleted the add-no-auth-option branch October 27, 2023 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Setup without token for offline commands such as app spec validation
2 participants