Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gofmt_check makefile target. #946

Merged
merged 2 commits into from
Jan 22, 2021
Merged

Fix gofmt_check makefile target. #946

merged 2 commits into from
Jan 22, 2021

Conversation

andrewsomething
Copy link
Member

Happened to notice that our gofmt_check makefile target is not running correctly in CI:

https://github.com/digitalocean/doctl/runs/1751541753?check_suite_focus=true#step:5:8

Output before change:

asb@asb-home:~/development/gocode/src/github.com/digitalocean/doctl$ make gofmt_check
==> ensure code adheres to gofmt (with vendor directory excluded)

/bin/sh: 1: read: arg count
asb@asb-home:~/development/gocode/src/github.com/digitalocean/doctl$ echo $?
0

Output after change:

asb@asb-home:~/development/gocode/src/github.com/digitalocean/doctl$ make gofmt_check
==> ensure code adheres to gofmt (with vendor directory excluded)

gofmt checking failed:

./commands/validations.go 

make: *** [Makefile:112: gofmt_check] Error 1
asb@asb-home:~/development/gocode/src/github.com/digitalocean/doctl$ echo $?
2

Copy link
Contributor

@ChiefMateStarbuck ChiefMateStarbuck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sweet!

@andrewsomething andrewsomething merged commit 584627a into main Jan 22, 2021
@andrewsomething andrewsomething deleted the gofmt-check branch January 22, 2021 22:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants