Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

apps: Support pagination. #976

Merged
merged 2 commits into from
Apr 13, 2021
Merged

apps: Support pagination. #976

merged 2 commits into from
Apr 13, 2021

Conversation

andrewsomething
Copy link
Member

Requires a new godo release for: digitalocean/godo#443

Fixes: #975

@andrewsomething andrewsomething marked this pull request as ready for review April 12, 2021 15:37
@scotchneat
Copy link
Contributor

When I test go run cmd/doctl/main.go apps ls, I get the following response:

Error: GET https://api.digitalocean.com/v2/apps?page=1&per_page=200: 400 cannot retrieve more than 25 items per page

It looks like the default perPage value is 200 and can't be configured when calling PaginateResp().

@andrewsomething
Copy link
Member Author

@scotchneat Yup, there is still a change that needs to happen on the API side to make Apps pagination consistent with the rest of the API.

@andrewsomething andrewsomething requested a review from a team April 13, 2021 15:35
Copy link
Contributor

@scotchneat scotchneat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@andrewsomething andrewsomething merged commit b4ef7c3 into main Apr 13, 2021
@ChiefMateStarbuck ChiefMateStarbuck deleted the asb/issues/975 branch March 7, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't (un)set result limit count
2 participants