New digitalocean_volume_attachment
resource for proper updates of droplet volumes
#130
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds an additional virtual resource named
digitalocean_volume_attachment
, which represents a volume attachment to a droplet. Replaces the current way of attaching volumes by passing in their ids to the droplet definition.Using the attachment resource allows terraform to correctly traverse the dependency graph of our resources and enables the provider to gracefully update any attached volumes. It does so by first detaching the volumes from the droplet, deleting old ones, creating new ones and finally reattaching the new volumes to the initial droplet.
Backward compatibility is preserved. You can continue using the current way of attaching volumes to droplets without issue. Just keep in mind that the methods are mutually exclusive. You must not use both of them at the same time. The documentation is also updated accordingly. Fixes #87
Example of the attachment resource: