Merge pull request #22759 from dimagi/rn_fix_related_location

Add clean method for related locations
dimagi · Dec 17, 2018 · a2cd6bc · a2cd6bc
2 parents 8a3ac07 + 6401c45
commit a2cd6bc
Showing 1 changed file with 5 additions and 1 deletion.
diff --git a/corehq/apps/locations/forms.py b/corehq/apps/locations/forms.py
@@ -682,8 +682,12 @@ def clean(self):
             if name.startswith('relation_distance_') and value and value < 0:
                 raise forms.ValidationError("The distance cannot be a negative value")
 
+    def clean_related_locations(self):
+        # Django uses get by default, but related_locations is actually a list
+        return self.data.getlist('related_locations')
+
     def save(self):
-        selected_location_ids = self.cleaned_data['related_locations'].split(',')
+        selected_location_ids = self.cleaned_data['related_locations']
         selected_location_ids = set(list(filter(None, selected_location_ids)))
 
         previous_location_ids = self.related_location_ids