Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Feature Flag from Ls dashboard #22831

Merged
merged 1 commit into from
Dec 26, 2018
Merged

Remove Feature Flag from Ls dashboard #22831

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions custom/icds_reports/static/icds_reports/js/spec/navigation.directive.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,9 +11,7 @@ describe('Navigation Directive', function () {
var $rootScope, $compile, $httpBackend, controller;

var myScope;
beforeEach(module('icdsApp', function ($provide) {
$provide.constant("haveAccessToFeatures", false);
}));
beforeEach(module('icdsApp'));

beforeEach(inject(function (_$rootScope_, _$compile_, _$httpBackend_) {
$compile = _$compile_;
Expand Down
5 changes: 2 additions & 3 deletions custom/icds_reports/static/js/directives/navigation/navigation.directive.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,11 +2,10 @@

var url = hqImport('hqwebapp/js/initial_page_data').reverse;

function NavigationController($window, $scope, $route, $routeParams, $location, haveAccessToFeatures) {
function NavigationController($window, $scope, $route, $routeParams, $location) {
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implicit global variable, assign as global property instead. (no-implicit-globals)

$scope.$route = $route;
$scope.$location = $location;
$scope.$routeParams = $routeParams;
$scope.haveAccessToFeatures = haveAccessToFeatures;

var checkColapse = function(reports) {
var path = _.filter(reports, function(report) { return $location.path().indexOf(report) !== -1; });
Expand Down Expand Up @@ -38,7 +37,7 @@ function NavigationController($window, $scope, $route, $routeParams, $location,
};
}

NavigationController.$inject = ['$window', '$scope', '$route', '$routeParams', '$location', 'haveAccessToFeatures'];
NavigationController.$inject = ['$window', '$scope', '$route', '$routeParams', '$location'];

window.angular.module('icdsApp').directive('navigation', function() {
return {
Expand Down
2 changes: 1 addition & 1 deletion custom/icds_reports/templates/icds_reports/icds_app/navigation.directive.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,7 +137,7 @@
<div class="col-sm-9">{% trans "AWC Report" %}</div>
</a>
</li>
<li ng-if="haveAccessToFeatures" ng-class="{'active': $location.path().indexOf('/lady_supervisor') !== -1}">
<li ng-class="{'active': $location.path().indexOf('/lady_supervisor') !== -1}">
<a class="row pointer" href="{$ goToStep('lady_supervisor', $location.search()) $}" style="width: 100%" ng-click="healthCollapsed = true; icdsCasReach = true; demographics = true; infrastructure = true;">
<div class="col-sm-1"><i class="fa fa-tasks" aria-hidden="true"></i></div>
<div class="col-sm-9">{% trans "LS Dashboard" %}</div>
Expand Down