Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Missed minor version bump? #1328

Open
Nashenas88 opened this issue Dec 4, 2023 · 2 comments
Open

Missed minor version bump? #1328

Nashenas88 opened this issue Dec 4, 2023 · 2 comments

Comments

@Nashenas88
Copy link

I ran into an issue where data I had serialized previously failed to deserialize. I was able to track it down to v0.32.2...v0.32.3#diff-627412b64dcb29bce666a665846074cc243329d6c336e70fcf9d04da018f6793R195 where the serialization of anything backed by array storage is now different. In my project I'm using postcard as the serialization format, and the two are encoded differently.

That seems like a big enough change in behavior to have needed a bump from 0.32.2 to 0.33.0 (as opposed to 0.32.3). Not sure if it's worth it now but thought I should bring it up in case you all could consider changing how you bump versions in the future. It took me a couple days to figure out what was going wrong.

@Ralith
Copy link
Collaborator

Ralith commented Dec 4, 2023

Yep, you're the second to report this. We should probably yank and bump.

@Andlon
Copy link
Collaborator

Andlon commented Dec 4, 2023

I agree with @Ralith here. @sebcrozet would you be willing to yank and publish a new minor version whenever you are able to find the time?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants