Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inconsistent TOI between ball-vs-ball and support-map-vs-support-map #106

Open
dubrowgn opened this issue Nov 17, 2022 · 0 comments
Open

Comments

@dubrowgn
Copy link

dubrowgn commented Nov 17, 2022

In v0.11.1, time-of-impact queries are returning inconsistent results for toi=0, depending on which shapes are involved.

If both shapes are balls, toi=0 results in status=converged (https://github.com/dimforge/parry/blob/v0.11.1/src/query/time_of_impact/time_of_impact_ball_ball.rs#L45)

	 let status = if inside && center.coords.norm_squared() < rsum * rsum {
	 	 TOIStatus::Penetrating
	 } else {
	 	 TOIStatus::Converged
	 };

If one shape is a cuboid, and the other a ball, toi=0 results in status=penetrating (https://github.com/dimforge/parry/blob/v0.11.1/src/query/time_of_impact/time_of_impact_support_map_support_map.rs#L50):

	status: if toi.is_zero() {
		TOIStatus::Penetrating
	} else {
		TOIStatus::Converged
	},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant