Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rapier3d doesn't compile with simd-nightly #633

Closed
cybersoulK opened this issue May 20, 2024 · 6 comments
Closed

rapier3d doesn't compile with simd-nightly #633

cybersoulK opened this issue May 20, 2024 · 6 comments
Labels
C-Bug Something isn't working D-Medium P-High

Comments

@cybersoulK
Copy link

rapier3d = { version = "0.19.0", features = ["simd-nightly"] }

I have been patching rapier3d 0.18.0 with the following:
simba = { git = "https://github.com/dimforge/simba", branch = "master" } #fixes packed_simd2 dep

but since recently, it stopped working and it can't compile. Including rapier 0.19.0

@Vrixyz Vrixyz added C-Bug Something isn't working breaking change This will result in a breaking change and removed breaking change This will result in a breaking change labels May 20, 2024
@cybersoulK
Copy link
Author

rust-lang/packed_simd#360 (comment)
forgot to say. My machine target is arch64, haven't tested with other targets.

@Vrixyz
Copy link
Contributor

Vrixyz commented Jun 4, 2024

Thanks for providing context, the linked comment helps understanding we have to migrate from packed_simd to std::simd in simba. Existing issue in simba: dimforge/simba#33

@waywardmonkeys
Copy link
Contributor

@cybersoulK I think this works now in rapier 0.21 since 3004a7d updated simba.

@cybersoulK
Copy link
Author

cybersoulK commented Jul 18, 2024

@cybersoulK I think this works now in rapier 0.21 since 3004a7d updated simba.

no, the issue has not been fixed yet. (0.21)
It needs to implement std::simd, and i don't see it yet.
(not sure what happened when i tested it, but it works now)

@waywardmonkeys
Copy link
Contributor

@cybersoulK In simba, the recent release removed the packed_simd feature and suggested using the portable_simd feature.

If you look in samba's src/simd/portable_simd_impl.rs, you'll see that it is using std::simd.

Further, compiling current parry with a nightly compiler and --features simd-nightly works for me.

@cybersoulK
Copy link
Author

@waywardmonkeys

i can confirm that both of these work:

rapier3d = { version = "0.21.0", features = ["simd-nightly"] }
rapier3d = { version = "0.22.0", features = ["simd-nightly"] }

thank you! i will close the issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
C-Bug Something isn't working D-Medium P-High
Projects
None yet
Development

No branches or pull requests

3 participants