Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add workflow to ensure conventional style on pull requests #21

Merged
merged 3 commits into from
Mar 12, 2021

Conversation

Namchee
Copy link
Collaborator

@Namchee Namchee commented Feb 6, 2021

Overview

This pull request adds a workflow to ensure that all submitted pull request follows the conventional commit convention.

The workflow itself uses my personal GitHub Action, conventional-pr.

Note: The workflow will fail right now, since we haven't set the ACCESS_TOKEN yet.

@Namchee Namchee requested a review from chez14 February 6, 2021 10:50
@chez14
Copy link
Member

chez14 commented Feb 6, 2021

Can ACCESS_TOKEN be sourced from GH_TOKEN?

@Namchee
Copy link
Collaborator Author

Namchee commented Feb 6, 2021

@chez14 , technically it's anything that you find under the Personal Access Token tab on the Settings page, so I think you can use GH_TOKEN but I need to confirm it.

@chez14
Copy link
Member

chez14 commented Feb 7, 2021

Gotcha. You may use the token to do that. The token should provide enough level to close, reject and comment the PR as it usually be.

Anyway, as this is quite trivia, i can change this one by my self when i'm free. Or if you don't want to wait, you have my permission to use the token for this ;)

Thank you for the hard work, this hopefully will serve enough data for you to test and improve your projects as i will definitely always be rejected by this PR lol.


Quick question, is there any chance that this will reject PR from Dependabot??

@chez14 chez14 added skip-release Preserve the current version when merged tests Add or improve existing tests labels Feb 7, 2021
@Namchee
Copy link
Collaborator Author

Namchee commented Feb 8, 2021

@chez14, unfortunately it will.

Great catch though, it's a new options then!

@Namchee
Copy link
Collaborator Author

Namchee commented Feb 8, 2021

@chez14, I've bumped the version. Should be okay to use dependabot now.

@chez14 chez14 merged commit e137425 into master Mar 12, 2021
@chez14 chez14 deleted the conventional-styles branch March 12, 2021 23:14
@repurika
Copy link
Collaborator

🚀 PR was released in v0.2.0 🚀

@repurika repurika added the released This issue/pull request has been released. label Mar 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
released This issue/pull request has been released. skip-release Preserve the current version when merged tests Add or improve existing tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants