Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Node.js 18 for Docker image #16810

Merged
merged 1 commit into from
Dec 18, 2022
Merged

Use Node.js 18 for Docker image #16810

merged 1 commit into from
Dec 18, 2022

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Dec 13, 2022

Description

Since v18 is the current active LTS of Node.js we should move to this version in the Docker image as well.

I'm not aware of any breaking changes from v16 -> v18 which could lead to issues, but I'd like to have this confirmed by others.
On the other hand v18 comes with a few interesting updates and features, see the release announcement.
For example the update of the V8 engine and things like FormData which became available (ref #16777).

Built and tested locally ✅

Type of Change

  • Bugfix
  • Improvement
  • New Feature
  • Refactor / codestyle updates
  • Other, please describe:

Requirements Checklist

  • New / updated tests are included
  • All tests are passing locally
  • Performed a self-review of the submitted code

If adding a new feature:

  • Documentation was added/updated. PR:

@MentalGear
Copy link

This would be much appreciated!

@rijkvanzanten rijkvanzanten merged commit f468dfb into directus:main Dec 18, 2022
@paescuj paescuj deleted the use-node-18-docker-image branch December 18, 2022 08:21
@MentalGear
Copy link

MentalGear commented Dec 18, 2022 via email

@rijkvanzanten rijkvanzanten added this to the Next Release milestone Dec 21, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants