Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix collection selection in field duplication #19732

Merged
merged 4 commits into from
Sep 19, 2023
Merged

Conversation

paescuj
Copy link
Member

@paescuj paescuj commented Sep 19, 2023

Fixes #19413

Replacing v-select with the system-collection interface to fix the search functionality but also to ensure that only collections are displayed and not folders.

Before

After

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

🦋 Changeset detected

Latest commit: 6ebfb0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@directus/app Patch
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@paescuj paescuj requested review from a team, rijkvanzanten, jaads and azrikahar and removed request for a team September 19, 2023 09:17
@jaads
Copy link
Member

jaads commented Sep 19, 2023

how come that I don't see the search field at all? 😆
Screenshot 2023-09-19 at 14 08 23

@paescuj
Copy link
Member Author

paescuj commented Sep 19, 2023

how come that I don't see the search field at all? 😆 Screenshot 2023-09-19 at 14 08 23

Search is only activated if there are more than 20 items in the list. (I'll submit another PR with the proposal to reduce that number to 10 😉)

@jaads
Copy link
Member

jaads commented Sep 19, 2023

Ohh I see, thanks!

@rijkvanzanten rijkvanzanten merged commit a6de008 into main Sep 19, 2023
5 checks passed
@rijkvanzanten rijkvanzanten deleted the fix-duplicate-field branch September 19, 2023 14:08
@github-actions github-actions bot added this to the Next Release milestone Sep 19, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* Fix collection selection in field duplication

* Add changeset

* Remove unused import

---------

Co-authored-by: rijkvanzanten <rijkvanzanten@me.com>
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Search in "duplicate field" dialog doesn't work
3 participants