Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle extension names in npm org scopes #20209

Merged
merged 2 commits into from
Oct 26, 2023
Merged

Handle extension names in npm org scopes #20209

merged 2 commits into from
Oct 26, 2023

Conversation

rijkvanzanten
Copy link
Member

Scope

Extensions can have an optional npm scope at the start (@<org>/<package>). This introduces an extra /, breaking the bundle splitting.

What's changed:

  • Add logic to handle extension names starting with an organization scope

Potential Risks / Drawbacks

  • We do expect package names to adhere to "npm rules". There shouldn't be any additional / characters beyond the organization scope

Review Notes / Questions


Fixes #20142

@changeset-bot
Copy link

changeset-bot bot commented Oct 26, 2023

🦋 Changeset detected

Latest commit: 92f453c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@directus/api Patch
directus Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Member

@paescuj paescuj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@rijkvanzanten rijkvanzanten merged commit 9afbc6e into main Oct 26, 2023
6 checks passed
@rijkvanzanten rijkvanzanten deleted the issue/20142 branch October 26, 2023 22:41
@github-actions github-actions bot added this to the Next Patch Release milestone Oct 26, 2023
br-rafaelbarros pushed a commit to personal-forks/directus-source that referenced this pull request Nov 7, 2023
* Handle extension names in npm org scopes

Fixes directus#20142

* Add changeset
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 1, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extensions with multiple / in name, do not show up in the Extensions panel.
2 participants