Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add GenericMessageEvent#getThreadChannel() #1924

Merged
merged 4 commits into from
Dec 2, 2021
Merged

Add GenericMessageEvent#getThreadChannel() #1924

merged 4 commits into from
Dec 2, 2021

Conversation

rtm516
Copy link
Contributor

@rtm516 rtm516 commented Dec 1, 2021

Pull Request Etiquette

Changes

  • Internal code
  • Library interface (affecting end-user code)
  • Documentation
  • Other: _____

Closes Issue: NaN

Description

Adds a missing GenericMessageEvent#getThreadChannel() to v5

@rtm516 rtm516 changed the base branch from v5 to master December 1, 2021 21:03
@MinnDevelopment
Copy link
Member

Can you add a isFromThread() to the event, that should make things a bit easier to handle on user end.

@DV8FromTheWorld DV8FromTheWorld merged commit 78803d6 into discord-jda:master Dec 2, 2021
@rtm516 rtm516 deleted the v5 branch December 2, 2021 18:17
@renovate renovate bot mentioned this pull request Jan 8, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MinnDevelopment MinnDevelopment MinnDevelopment left review comments

@DV8FromTheWorld DV8FromTheWorld DV8FromTheWorld approved these changes

Assignees
No one assigned
Labels
type: enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@rtm516 @MinnDevelopment @DV8FromTheWorld